From 5bfc8e4f3cbb81ce174166319561d83f538c0b45 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 9 Jan 2025 14:30:09 +0100 Subject: [PATCH] Bug 38854: Remove 'class' property from ToolbarButton We never use another value than the default one. We can simply remove this property. Test plan: Rebuild the dist files using `yarn js:build` and confirm that the buttons in the toolbar of the ERM and Preservation modules still appears and are styled like before. --- .../prog/js/vue/components/ERM/AgreementsShow.vue | 7 +------ .../js/vue/components/ERM/EHoldingsLocalPackagesShow.vue | 1 - .../js/vue/components/ERM/EHoldingsLocalTitlesShow.vue | 1 - .../prog/js/vue/components/ERM/LicensesShow.vue | 1 - .../components/ERM/UsageStatisticsDataProvidersShow.vue | 1 - .../components/Preservation/SettingsProcessingsShow.vue | 1 - .../prog/js/vue/components/Preservation/TrainsShow.vue | 3 +-- .../intranet-tmpl/prog/js/vue/components/ToolbarButton.vue | 6 +----- 8 files changed, 3 insertions(+), 18 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsShow.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsShow.vue index 7b49fe88d67..3397dd4ae81 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsShow.vue +++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsShow.vue @@ -7,15 +7,10 @@ name: 'AgreementsFormAddEdit', params: { agreement_id: agreement.agreement_id }, }" - class="btn btn-default" icon="pencil" :title="$__('Edit')" /> - {{ $__("Delete") }} diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesShow.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesShow.vue index 5f73b9d80d4..8c949f54ae7 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesShow.vue +++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesShow.vue @@ -7,7 +7,6 @@ name: 'EHoldingsLocalPackagesFormAddEdit', params: { package_id: erm_package.package_id }, }" - class="btn btn-default" icon="pencil" :title="$__('Edit')" /> diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesShow.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesShow.vue index fbe7ac27524..3fea73d2702 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesShow.vue +++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesShow.vue @@ -7,7 +7,6 @@ name: 'EHoldingsLocalTitlesFormAddEdit', params: { title_id: title.title_id }, }" - class="btn btn-default" icon="pencil" :title="$__('Edit')" /> diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesShow.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesShow.vue index f1d545ac423..9f602f4e112 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesShow.vue +++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesShow.vue @@ -7,7 +7,6 @@ name: 'LicensesFormAddEdit', params: { license_id: license.license_id }, }" - class="btn btn-default" icon="pencil" :title="$__('Edit')" /> diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProvidersShow.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProvidersShow.vue index 1643dbc91ad..42a0197d639 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProvidersShow.vue +++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProvidersShow.vue @@ -10,7 +10,6 @@ usage_data_provider.erm_usage_data_provider_id, }, }" - class="btn btn-default" icon="pencil" :title="$__('Edit')" /> diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/SettingsProcessingsShow.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/SettingsProcessingsShow.vue index 82c35eeaf2b..4c136203089 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/SettingsProcessingsShow.vue +++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/SettingsProcessingsShow.vue @@ -7,7 +7,6 @@ name: 'SettingsProcessingsFormEdit', params: { processing_id: processing.processing_id }, }" - class="btn btn-default" icon="pencil" :title="$__('Edit')" /> diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/TrainsShow.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/TrainsShow.vue index 9b3496b09d5..576ccda0c12 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/TrainsShow.vue +++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/TrainsShow.vue @@ -79,7 +79,6 @@ name: 'TrainsFormAddItem', params: { train_id: train.train_id }, }" - class="btn btn-default" icon="plus" :title="$__('Add items')" /> @@ -96,7 +95,7 @@ name: 'TrainsFormEdit', params: { train_id: train.train_id }, }" - class="btn btn-default" + _class="btn btn-default" icon="pencil" :title="$__('Edit')" /> diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ToolbarButton.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ToolbarButton.vue index 4cfada715cc..f44fb9d3cdc 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ToolbarButton.vue +++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ToolbarButton.vue @@ -1,5 +1,5 @@ @@ -10,10 +10,6 @@ export default { to: { type: [String, Object], }, - class: { - type: String, - default: "btn btn-default", - }, icon: { type: String, required: false, -- 2.34.1