From 426d39511396f56c073fbac2431174aea349cd7c Mon Sep 17 00:00:00 2001 From: Hammat Wele Date: Mon, 12 Aug 2024 21:40:43 +0000 Subject: [PATCH] Bug 37622: Error in erm module when editing an agreement, a license, a package or a titles To reproduce 1- Enable the ERMModule system preference 1- Go to Administration > System Preferences 2- Search for ERMModule 3- Change the value to "Enable" 4- Click on "Save all e-resource management preferences" 5- Return to the main screen 1- Create an agreement 1- Go to e-resource management 2- Click on "Agreements" 3- Click on "New agreement" 4- Fill out the form (mandatory fields) - Agreement name: Natural Medicines - Status: Active 5- Click on "Submit" 2- Edit the agreement 1- Click on "Agreements" 2- Click on "Edit" to the right of the Natural Medicines agreement 3- Click on "Submit" --> Something went wrong: SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data We got the same error when editing a license, a package or a title --- Koha/REST/V1/ERM/Agreements.pm | 5 ----- Koha/REST/V1/ERM/EHoldings/Titles/Local.pm | 1 - 2 files changed, 6 deletions(-) diff --git a/Koha/REST/V1/ERM/Agreements.pm b/Koha/REST/V1/ERM/Agreements.pm index 5a82b102f4..a8f6f7ea21 100644 --- a/Koha/REST/V1/ERM/Agreements.pm +++ b/Koha/REST/V1/ERM/Agreements.pm @@ -195,11 +195,6 @@ sub update { $agreement->agreement_relationships($agreement_relationships); $agreement->documents($documents); - my @extended_attributes = - map { { 'id' => $_->{field_id}, 'value' => $_->{value} } } @{$extended_attributes}; - $agreement->extended_attributes( \@extended_attributes ); - - $c->res->headers->location($c->req->url->to_string . '/' . $agreement->agreement_id); return $c->render( status => 200, openapi => $c->objects->to_api($agreement), diff --git a/Koha/REST/V1/ERM/EHoldings/Titles/Local.pm b/Koha/REST/V1/ERM/EHoldings/Titles/Local.pm index ac8818afe5..90ead1f480 100644 --- a/Koha/REST/V1/ERM/EHoldings/Titles/Local.pm +++ b/Koha/REST/V1/ERM/EHoldings/Titles/Local.pm @@ -170,7 +170,6 @@ sub update { $title->resources($resources); - $c->res->headers->location($c->req->url->to_string . '/' . $title->title_id); return $c->render( status => 200, openapi => $c->objects->to_api($title), -- 2.43.0