From 142cc45c7bad12e467d2704e51c0df548cb5cb16 Mon Sep 17 00:00:00 2001 From: Victor Grousset/tuxayo Date: Sun, 22 Dec 2024 09:33:45 +0100 Subject: [PATCH] Bug 38770: Remove @vue/cli-service and babel And the webpack related dead config. Test plan: 1. Do not apply 2. Switch to node 22 sudo sed 's/18.x/22.x/g' -i /etc/apt/sources.list.d/nodesource.list sudo apt update ; sudo apt install nodejs 3. Try to install node deps sudo yarn install --modules-folder /kohadevbox/node_modules 4. It fails error @achrinza/node-ipc@9.2.5: The engine "node" is incompatible with this module. Expected version "8 || 9 || 10 || 11 || 12 || 13 || 14 || 15 || 16 || 17 || 18". Got "22.12.0" 5. Apply patches 6. Try to install node deps sudo yarn install --modules-folder /kohadevbox/node_modules 7. It works! :) Signed-off-by: David Nind Signed-off-by: Martin Renvoize --- cypress.config.ts | 7 ------- package.json | 6 ------ t/cypress/plugins/index.js | 14 ++++++-------- 3 files changed, 6 insertions(+), 21 deletions(-) diff --git a/cypress.config.ts b/cypress.config.ts index f2c3619efa9..e90da4e019d 100644 --- a/cypress.config.ts +++ b/cypress.config.ts @@ -24,11 +24,4 @@ export default defineConfig({ }, }, }, - - component: { - devServer: { - framework: "vue-cli", - bundler: "webpack", - }, - }, }); diff --git a/package.json b/package.json index 88421356857..dc13a1f3d17 100644 --- a/package.json +++ b/package.json @@ -15,8 +15,6 @@ "@fortawesome/vue-fontawesome": "^3.0.0-5", "@popperjs/core": "^2.11.6", "@redocly/cli": "^1.25.11", - "@vue/cli-service": "^5.0.1", - "babel-core": "^7.0.0-beta.3", "bootstrap": "^5.3.3", "css-loader": "^6.6.0", "cypress": "^12.17.2", @@ -71,13 +69,9 @@ "author": "", "license": "GPL-3.0", "devDependencies": { - "@babel/core": "^7.17.5", - "@babel/preset-env": "^7.16.11", "@rspack/cli": "^1.0.1", "@rspack/core": "^1.0.1", "@vue/compiler-sfc": "^3.2.31", - "babel-loader": "^8.2.3", - "babelify": "^10.0.0", "browserify": "^17.0.0", "clean-webpack-plugin": "^4.0.0", "eslint": "^9.12.0", diff --git a/t/cypress/plugins/index.js b/t/cypress/plugins/index.js index 6a5e123a864..6f14a7f4f9e 100644 --- a/t/cypress/plugins/index.js +++ b/t/cypress/plugins/index.js @@ -1,13 +1,11 @@ -const { startDevServer } = require("@cypress/webpack-dev-server"); -const webpackConfig = require("@vue/cli-service/webpack.config.js"); +const { startDevServer } = require('@cypress/webpack-dev-server') module.exports = (on, config) => { - on("dev-server:start", options => - startDevServer({ - options, - webpackConfig, - }) - ); + on('dev-server:start', options => + startDevServer({ + options, + }) + ) return config; }; -- 2.34.1