From b5aeb7d78946ab465a99c5db35d0b1372599636c Mon Sep 17 00:00:00 2001 From: Brendan Lawlor Date: Tue, 15 Oct 2024 12:39:47 +0000 Subject: [PATCH] Bug 38174: Fix self checkout alerts for non batch checkouts This patch adds a check for batch_checkouts_allowed to SCO. If not using batch checkout, only the most recent chekout should be rendered as an alert, instead of all the new issues for the session. This makes the input box consitently render in the same position. To replicate: 1. Login as self_checkout to localhost:8080/cgi-bin/koha/sco/sco-main.pl 2. Login as a patron to make self checkouts 3. Check many items out and notice an additional alert is rendered for each checkout, eventually pushing the barcode input off screen. To test: 1. Apply patch and restart_alll 2. Login as a patron to make self checkouts 3. Check many items out 4. Notice only the most recent checkout is rendered as an info alert 5. Confirm the Checkouts table below still loads all checkouts 6. In Admin set BatchCheckouts to 'Allow' 7. Set SCOBatchCheckoutsValidCategories to 'Select all' 8. Login to sco as a patron and enter a newline delimited list of barcodes 9. Confirm that an alert is rendered for each checkout in the batch Signed-off-by: Lucas Gass Signed-off-by: Paul Derscheid --- .../bootstrap/en/modules/sco/sco-main.tt | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt index 92c4b69146..206b3c3491 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt @@ -214,11 +214,18 @@ [% END %] [% IF ( issued ) %] - [% FOREACH barcode IN newissues.split(',') %] - -
-

Item checked out ([% barcode | html %])

-
+ [% IF batch_checkouts_allowed %] + [% FOREACH barcode IN newissues.split(',') %] + +
+

Item checked out ([% barcode | html %])

+
+ [% END %] + [% ELSE %] + +
+

Item checked out ([% newissues.split(',').last | html %])

+
[% END %] [% ELSIF ( renewed ) %] -- 2.39.5