From a4269f0a344dc3521cd372bccdcec65ab793a950 Mon Sep 17 00:00:00 2001 From: Phil Ringnalda Date: Fri, 17 Jan 2025 14:26:06 -0800 Subject: [PATCH] Bug 38921: Remove unused href from Cancel hold link The trashcan icon to cancel a hold from the list of holds on a bib record has a leftover href attribute from before the bug 34478 CSRF protection changes. It has an 'op=cancel' which does nothing since there's only a cud-cancel op, so it just falls through to the view case and redisplays the page if you open it in a new tab, and doesn't get used at all if you click the trashcan, when JavaScript builds up a form that you can POST. Test plan: 1. Place a hold on any item. 2. On the list of holds, right-click the Cancel hold trashcan icon, and select Open in new tab 3. In the new tab, note that the URL in the browser address bar shows all sorts of things about op=cancel and borrowernumber and biblionumber and reserveid, but nothing changed, your hold wasn't deleted 4. Close that pointless tab, and apply patch 5. Reload the page with the list of holds, and again right-click the Cancel hold trashcan and select Open in new tab 6. In the new tab, note that the URL just has the biblionumber and a #, no other extraneous things 7. In the original tab, left-click the trashcan, confirm cancellation in the popup, and make sure that cancelling still does work. Sponsored-by: Chetco Community Public Library Signed-off-by: David Nind --- koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc index dd99815cb2..8b8addf15e 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc @@ -237,7 +237,7 @@ [%- END -%] [%- END -%] - + -- 2.39.5