From fd066174f576aae1391cdd66cbd295e937f39e35 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 23 Jan 2025 12:05:02 +0100 Subject: [PATCH] Bug 38954: Hide checkout type using colvis Content-Type: text/plain; charset=utf-8 This is not the correct way to hide a column, we should use the DT's column visibility plugin. Test plan: Have some checkouts for a patron, go to the checkout history page Without this patch notice the "shift" => the table does not take the whole available width. Apply this patch, restart_all, remove localStorage entries => The table is now displayed properly You can also play with on-site checkouts. Before: https://snipboard.io/uTWYit.jpg https://snipboard.io/qxZE35.jpg After: https://snipboard.io/2L0F3Q.jpg Signed-off-by: David Nind Signed-off-by: Marcel de Rooy --- admin/columns_settings.yml | 1 + koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml index f0f50415fa..2a632acc25 100644 --- a/admin/columns_settings.yml +++ b/admin/columns_settings.yml @@ -1420,6 +1420,7 @@ modules: - columnname: type cannot_be_toggled: 1 cannot_be_modified: 1 + is_hidden: 1 - columnname: date - diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt index 8558bd2ad1..de899d726e 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt @@ -62,7 +62,7 @@ - + @@ -84,7 +84,7 @@ [% SET item = checkout.item %] [% SET biblio = item.biblio %] -
TypeType Date Title Author
+ [% IF checkout.onsite_checkout %][% issuetype = 'onsite_checkout' | html %] [% ELSE %][% issuetype = 'standard_checkout' | html %] [% END %] -- 2.39.5