From 6410c0595537af17e9ef7ddeef068d17ff9088e1 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 27 Jan 2025 09:56:30 +0100 Subject: [PATCH] Bug 38969: Prevent JS error when adding tags with quote at the OPAC Uncaught SyntaxError: missing ) after argument list There are way more to fix in this controller... --- opac/opac-tags.pl | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/opac/opac-tags.pl b/opac/opac-tags.pl index e9333dee161..e71dc475a05 100755 --- a/opac/opac-tags.pl +++ b/opac/opac-tags.pl @@ -200,7 +200,8 @@ if ($is_ajax) { my $i = 1; foreach (@errors) { my $key = (keys %$_)[0]; - $err_string .= "\n\t\t KOHA.Tags.tag_message.$key(\"" . $_->{$key} . '")'; + ( my $quote_escaped = $_->{$key} ) =~ s|"|\\"|g; + $err_string .= sprintf qq{\n\t\t KOHA.Tags.tag_message.%s("%s")}, $key, $quote_escaped; if($i < scalar @errors){ $err_string .= ","; } $i++; } @@ -216,8 +217,9 @@ if ($is_ajax) { my $i = 0; foreach (@{$bibResult->{errors}}) { $js_bibres .= "," if ($i); - my $key = (keys %$_)[0]; - $js_bibres .= "\n\t\t\t KOHA.Tags.tag_message.$key(\"" . $_->{$key} . '")'; + my $key = (keys %$_)[0]; + ( my $quote_escaped = $_->{$key} ) =~ s|"|\\"|g; + $js_bibres .= sprintf qq{\n\t\t\t KOHA.Tags.tag_message.%s("%s")}, $key, $quote_escaped; $i++; } $js_bibres .= "\n\t\t]\n\t}"; -- 2.34.1