Bugzilla – Attachment 17722 Details for
Bug 9743
Allow customization for making hold notes required
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9743: Unit test for mandatory hold notes
Bug-9743-Unit-test-for-mandatory-hold-notes.patch (text/plain), 3.31 KB, created by
Marcel de Rooy
on 2013-04-26 14:56:47 UTC
(
hide
)
Description:
Bug 9743: Unit test for mandatory hold notes
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2013-04-26 14:56:47 UTC
Size:
3.31 KB
patch
obsolete
>From c617344ffb0c8f09789a7acd16c39731a58ff58a Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Wed, 6 Mar 2013 14:58:29 +0100 >Subject: [PATCH] Bug 9743: Unit test for mandatory hold notes >Content-Type: text/plain; charset=utf-8 > >Test plan: >Export PERL5LIB and KOHA_CONF to your test database. >Run t/db_dependent/Reserves.t. >You should have 7 tests running ok. >--- > t/db_dependent/Reserves.t | 29 ++++++++++++++++++++++++----- > 1 files changed, 24 insertions(+), 5 deletions(-) > >diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t >index 1e20318..19d5a0b 100755 >--- a/t/db_dependent/Reserves.t >+++ b/t/db_dependent/Reserves.t >@@ -4,7 +4,7 @@ use strict; > use warnings; > use C4::Branch; > >-use Test::More tests => 4; >+use Test::More tests => 7; > use MARC::Record; > use C4::Biblio; > use C4::Items; >@@ -21,8 +21,10 @@ diag("\nCreating biblio instance for testing."); > my ($bibnum, $title, $bibitemnum) = create_helper_biblio(); > > # Helper item for that biblio. >+my @branches = GetBranchesLoop(); >+my $branch = $branches[0][0]{value}; > diag("Creating item instance for testing."); >-my ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => 'CPL', holdingbranch => 'CPL' } , $bibnum); >+my ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $branch||'CPL', holdingbranch => $branch||'CPL' } , $bibnum); > > # Modify item; setting barcode. > my $testbarcode = '97531'; >@@ -50,9 +52,6 @@ my $notes = ''; > my $checkitem = undef; > my $found = undef; > >-my @branches = GetBranchesLoop(); >-my $branch = $branches[0][0]{value}; >- > AddReserve($branch, $borrowernumber, $biblionumber, > $constraint, $bibitems, $priority, $resdate, $expdate, $notes, > $title, $checkitem, $found); >@@ -66,6 +65,25 @@ ok($status eq "Reserved", "CheckReserves Test 2"); > ($status, $reserve, $all_reserves) = CheckReserves(undef, $barcode); > ok($status eq "Reserved", "CheckReserves Test 3"); > >+#tests for mandatory hold notes >+my $shownotes=C4::Context->preference('OPACShowHoldNotes'); >+my $mandnotes=C4::Context->preference('OPACMandatoryHoldNotes'); >+C4::Context->set_preference('OPACShowHoldNotes', 1); >+C4::Context->set_preference('OPACMandatoryHoldNotes', '1&2'); >+my $record=GetMarcBiblio($bibnum); >+my $retval= C4::Reserves::GetMandatoryNoteReason($bibnum,$record); >+ok($retval==1, "Mandatory hold notes test 1"); >+C4::Context->set_preference('OPACMandatoryHoldNotes', '4'); >+$retval= C4::Reserves::GetMandatoryNoteReason($bibnum,$record); >+ok($retval==0, "Mandatory hold notes test 2"); >+C4::Context->set_preference('OPACMandatoryHoldNotes', '1&2'); >+C4::Context->set_preference('OPACShowHoldNotes', 0); >+$retval= C4::Reserves::GetMandatoryNoteReason($bibnum,$record); >+ok($retval==0, "Mandatory hold notes test 3"); >+#reset prefs >+C4::Context->set_preference('OPACShowHoldNotes', $shownotes); >+C4::Context->set_preference('OPACMandatoryHoldNotes', $mandnotes); >+ > > # Teardown Test--------------------- > # Delete item. >@@ -83,6 +101,7 @@ sub create_helper_biblio { > $bib->append_fields( > MARC::Field->new('100', ' ', ' ', a => 'Moffat, Steven'), > MARC::Field->new('245', ' ', ' ', a => $title), >+ MARC::Field->new('300', ' ', ' ', a => '2 vols for triggering notes'), > ); > return ($bibnum, $title, $bibitemnum) = AddBiblio($bib, ''); > } >-- >1.7.7.6
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9743
:
15842
|
15843
|
15910
|
17720
|
17721
|
17722
|
19561
|
19562
|
19563
|
21233
|
21236
|
21240
|
21741
|
21742
|
21743
|
21744
|
34422
|
34526