Bugzilla – Attachment 17746 Details for
Bug 9684
Z39.50 Card View broken in CCSR
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 9684 : Correct path to compact.xsl
PASSED-QA-Bug-9684--Correct-path-to-compactxsl.patch (text/plain), 1.97 KB, created by
Katrin Fischer
on 2013-04-27 10:30:07 UTC
(
hide
)
Description:
[PASSED QA] Bug 9684 : Correct path to compact.xsl
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-04-27 10:30:07 UTC
Size:
1.97 KB
patch
obsolete
>From 6c2d9effe3169f0f8bbf89079b5df1fd077cc434 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Fri, 26 Apr 2013 17:11:37 +0100 >Subject: [PATCH] [PASSED QA] Bug 9684 : Correct path to compact.xsl > >When try to display card view of retrieved record >error occurred as compact.xsl could not be found >script was constructing path as though it was opac > >Also added fallback to en version if no xsl file >found under current lang as done in opac-showmarc.pl > >Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> >Test plan: > >* Set sys pref to use CCSR >* Do a Z39.50 Search >* Click 'card' on one of the results >* confirm that there is no error. > >All test pass > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >I am astonished that opacthemes affects Z39.50 search in >staff so this might be fixing a bigger problem. > >Checked that clicking on Card works for both themes now >correctly after I confirmed the bug. >Also all views in OPAC were checked for both themes. > >All tests and QA script pass. >--- > catalogue/showmarc.pl | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > >diff --git a/catalogue/showmarc.pl b/catalogue/showmarc.pl >index 1c453c4..0ee70c5 100755 >--- a/catalogue/showmarc.pl >+++ b/catalogue/showmarc.pl >@@ -52,10 +52,13 @@ else { > } > > if($view eq 'card') { >- my $themelang = '/' . C4::Context->preference("opacthemes") . '/' . C4::Templates::_current_language(); >+ my $themelang = '/' . C4::Templates::_current_language(); > my $xmlrecord= $importid? $record->as_xml(): GetXmlBiblio($biblionumber); > my $xslfile = >- C4::Context->config('intrahtdocs') . $themelang . "/xslt/compact.xsl"; >+ C4::Context->config('intrahtdocs') . '/prog' . $themelang . "/xslt/compact.xsl"; >+ if ( ! -f $xslfile && $themelang ne '/en' ) { >+ $xslfile=~s#$themelang#/en#; >+ } > my $parser = XML::LibXML->new(); > my $xslt = XML::LibXSLT->new(); > my $source = $parser->parse_string($xmlrecord); >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9684
:
17727
|
17739
| 17746