From ddc336ec515aa26be50cc973a7cef03f52b2ce40 Mon Sep 17 00:00:00 2001 From: Arthur Suzuki Date: Tue, 4 Feb 2025 12:02:27 +0100 Subject: [PATCH] Bug 17656: (QA follow-up) fix compile errors Signed-off-by: David Nind --- serials/subscription-renew.pl | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/serials/subscription-renew.pl b/serials/subscription-renew.pl index d23945aee6..7d7aa343a9 100755 --- a/serials/subscription-renew.pl +++ b/serials/subscription-renew.pl @@ -88,7 +88,6 @@ if ( $op eq "cud-renew" ) { print $query->redirect("/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=$subscriptionid"); } - my @permanent_irregularities = $query->param('permanent_irregularity'); my @irregularities = $query->param('irregularity'); my $startdate = output_pref( { str => scalar $query->param('startdate'), dateonly => 1, dateformat => 'iso' } ); ($numberlength, $weeklength, $monthlength) = GetSubscriptionLength( $subtype, $sublength ); @@ -122,8 +121,9 @@ if ( $op eq "cud-renew" ) { $subscription = Koha::Subscriptions->find( $subscriptionid ); my @irregularities = $subscription->guess_irregularities; - $subscription->permanent_irregularity(join(';', @permanent_irregularities)); - $subscription->irregularity( join(';', @irregularities) ) + my @permanent_irregularities = $query->param('permanent_irregularity'); + $subscription->permanent_irregularity( join(';', @permanent_irregularities) ); + $subscription->irregularity( join(';', @irregularities) ); $subscription->store; } } @@ -193,7 +193,6 @@ else { $template->param( op => $op, - popup => ($mode eq 'popup'), ); output_html_with_http_headers $query, $cookie, $template->output; -- 2.39.5