From 86699046765926f958b7d8c89c9a9b5d01eb6be2 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 10 Feb 2025 11:31:34 +0100 Subject: [PATCH] Bug 36081: Fix some failing tests --- t/db_dependent/ArticleRequests.t | 13 +++++---- t/db_dependent/Koha/ArticleRequest.t | 41 ++++++++++++++++++---------- t/db_dependent/Koha/Biblio.t | 14 ++++++---- t/db_dependent/Koha/Patron.t | 14 ++++++---- 4 files changed, 53 insertions(+), 29 deletions(-) diff --git a/t/db_dependent/ArticleRequests.t b/t/db_dependent/ArticleRequests.t index 289015b4314..2b092019de2 100755 --- a/t/db_dependent/ArticleRequests.t +++ b/t/db_dependent/ArticleRequests.t @@ -69,12 +69,15 @@ my $patron_2 = $builder->build_object({ class => 'Koha::Patrons', value => { fla # store Koha::Notice::Messages->delete; my $article_request_title = 'an article request title'; -my $article_request = Koha::ArticleRequest->new( +my $article_request = $builder->build_object( { - borrowernumber => $patron->id, - biblionumber => $item->biblionumber, - itemnumber => $item->itemnumber, - title => $article_request_title, + class => 'Koha::ArticleRequests', + value => { + borrowernumber => $patron->id, + biblionumber => $item->biblionumber, + itemnumber => $item->itemnumber, + title => $article_request_title, + } } )->request(); diff --git a/t/db_dependent/Koha/ArticleRequest.t b/t/db_dependent/Koha/ArticleRequest.t index 8e32fc8cd45..de6bcdfb4b4 100755 --- a/t/db_dependent/Koha/ArticleRequest.t +++ b/t/db_dependent/Koha/ArticleRequest.t @@ -46,10 +46,14 @@ subtest 'request() tests' => sub { my $ar_module = mock_article_request_module(); - my $ar = Koha::ArticleRequest->new( + my $ar = $builder->build_object( { - borrowernumber => $patron->id, - biblionumber => $item->biblionumber, + class => 'Koha::ArticleRequests', + value => { + borrowernumber => $patron->id, + biblionumber => $item->biblionumber, + debit_id => undef, + } } ); @@ -67,11 +71,14 @@ subtest 'request() tests' => sub { # set a fee amount $amount = 10; - $ar = Koha::ArticleRequest->new( + $ar = $builder->build_object( { - borrowernumber => $patron->id, - biblionumber => $item->biblionumber, - itemnumber => $item->id, + class => 'Koha::ArticleRequests', + value => { + borrowernumber => $patron->id, + biblionumber => $item->biblionumber, + itemnumber => $item->id, + } } ); @@ -101,10 +108,13 @@ subtest 'set_pending() tests' => sub { my $ar_module = mock_article_request_module(); - my $ar = Koha::ArticleRequest->new( + my $ar = $builder->build_object( { - borrowernumber => $patron->id, - biblionumber => $biblio->id, + class => 'Koha::ArticleRequests', + value => { + borrowernumber => $patron->id, + biblionumber => $biblio->id, + } } ); @@ -174,11 +184,14 @@ subtest 'cancel() tests' => sub { my $ar_module = mock_article_request_module(); - my $ar = Koha::ArticleRequest->new( + my $ar = $builder->build_object( { - borrowernumber => $patron->id, - biblionumber => $item->biblionumber, - itemnumber => $item->id, + class => 'Koha::ArticleRequests', + value => { + borrowernumber => $patron->id, + biblionumber => $item->biblionumber, + itemnumber => $item->id, + } } ); diff --git a/t/db_dependent/Koha/Biblio.t b/t/db_dependent/Koha/Biblio.t index aa753903c09..dbc5a6bdb72 100755 --- a/t/db_dependent/Koha/Biblio.t +++ b/t/db_dependent/Koha/Biblio.t @@ -1461,12 +1461,16 @@ subtest 'article_requests() tests' => sub { my $patron = $builder->build_object( { class => 'Koha::Patrons' } ); - Koha::ArticleRequest->new( + $builder->build_object( { - borrowernumber => $patron->id, - biblionumber => $biblio->id, - itemnumber => $item->id, - title => $biblio->title, + class => 'Koha::ArticleRequests', + value => { + borrowernumber => $patron->id, + biblionumber => $biblio->id, + itemnumber => $item->id, + title => $biblio->title, + + } } )->request; } diff --git a/t/db_dependent/Koha/Patron.t b/t/db_dependent/Koha/Patron.t index 32189c6c953..8ad30494366 100755 --- a/t/db_dependent/Koha/Patron.t +++ b/t/db_dependent/Koha/Patron.t @@ -1348,12 +1348,16 @@ subtest 'article_requests() tests' => sub { my $item = $builder->build_sample_item; - Koha::ArticleRequest->new( + $builder->build_object( { - borrowernumber => $patron->id, - biblionumber => $item->biblionumber, - itemnumber => $item->id, - title => "Title", + class => 'Koha::ArticleRequests', + value => { + borrowernumber => $patron->id, + biblionumber => $item->biblionumber, + itemnumber => $item->id, + title => "Title", + + } } )->request; } -- 2.34.1