From 193452b302a6f7f6e56814190f9132309f60e3f6 Mon Sep 17 00:00:00 2001 From: Lucas Gass Date: Tue, 18 Jun 2024 14:15:32 +0000 Subject: [PATCH] Bug 36868: (follow-up) Fix staff interface code Signed-off-by: Sam Lau --- koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 4 ++-- reserve/placerequest.pl | 6 ++---- reserve/request.pl | 3 +-- 3 files changed, 5 insertions(+), 8 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt index a1b094a3b23..db96e5687f8 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ -1818,8 +1818,8 @@ [% END %] [% IF successful_holds && Koha.Preference('AutoDeleteFromCartWhenHoldPlaced').grep('staff').size %] - [% FOREACH biblionumber in successful_holds %] - delSingleRecord('[% biblionumber | html %]'); + [% FOREACH success IN successful_holds.split('\|') %] + delSingleRecord('[% success | html %]'); [% END %] [% END %] diff --git a/reserve/placerequest.pl b/reserve/placerequest.pl index 8d564793470..e2c1f1d9c55 100755 --- a/reserve/placerequest.pl +++ b/reserve/placerequest.pl @@ -171,10 +171,8 @@ if ( $op eq 'cud-placerequest' && $patron ) { foreach my $msg ( keys %failed_holds ) { push( @failed_hold_msgs, $msg ); } - $redirect_url->query_form( - biblionumber => [@biblionumbers], failed_holds => \@failed_hold_msgs, - successful_holds => \@successful_biblionumbers, - ); + $redirect_url->query_form( biblionumber => [@biblionumbers], failed_holds => \@failed_hold_msgs ); + $redirect_url .= "&successful_holds=" . join( '|', @successful_biblionumbers ); print $input->redirect($redirect_url); } elsif ( $borrowernumber eq '' ) { print $input->header(); diff --git a/reserve/request.pl b/reserve/request.pl index 6c27930b308..0ac6de26350 100755 --- a/reserve/request.pl +++ b/reserve/request.pl @@ -738,8 +738,7 @@ $template->param( biblionumbers => \@biblionumbers ); $template->param( pickup => $pickup || C4::Context->userenv->{branch} ); $template->param( borrowernumber => $borrowernumber_hold ); - -$template->param( failed_holds => \@failed_holds, successful_holds => \@successful_holds ); +$template->param( failed_holds => \@failed_holds, successful_holds => @successful_holds ); # printout the page output_html_with_http_headers $input, $cookie, $template->output; -- 2.39.5