From 60c71484bab5e4f3e2941fd0468003026b36666f Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 12 Feb 2025 06:37:06 +0100 Subject: [PATCH] Bug 38664: Fix updatedatabase.pl This patch fixes the following error: sort (...) interpreted as function at /kohadevbox/koha/installer/data/mysql/updatedatabase.pl line 25950. sort @words and sort { $a cmp $b } @words are functionally identical because Perl's default sort behavior is string-wise ascending order (which is exactly what { $a cmp $b } specifies). --- installer/data/mysql/updatedatabase.pl | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl index 33e645e0a40..adbd5e4c508 100755 --- a/installer/data/mysql/updatedatabase.pl +++ b/installer/data/mysql/updatedatabase.pl @@ -25947,8 +25947,10 @@ if ( CheckVersion($DBversion) ) { |, { Slice => {} } ); for my $suggestion (@$suggestions) { - my ($max_date) = sort ( $suggestion->{manageddate} || (), $suggestion->{accepteddate} || (), - $suggestion->{rejecteddate} || () ); + my ($max_date) = sort { $a cmp $b } ( + $suggestion->{manageddate} || (), $suggestion->{accepteddate} || (), + $suggestion->{rejecteddate} || () + ); next unless $max_date; my $last_modif_by = ( defined $suggestion->{manageddate} and $max_date eq $suggestion->{manageddate} ) -- 2.34.1