From 5dce773e89a683e54cb8fe34ac7919e61a592adc Mon Sep 17 00:00:00 2001 From: Aleisha Amohia Date: Thu, 9 Nov 2023 02:25:34 +0000 Subject: [PATCH] Bug 31391: Test fixes Signed-off-by: David Nind Signed-off-by: Pedro Amorim --- .../intranet-tmpl/prog/en/modules/recalls/request.tt | 2 +- t/db_dependent/Holds.t | 9 ++++++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/request.tt index 00a25cb1b91..cf7ca499227 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/request.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/request.tt @@ -53,7 +53,7 @@ [% END %] [% IF patron_holds_count %] -
Patron has placed one or more record-level holds. Convert a hold to a recall.
+
Patron has placed one or more record-level holds. Convert a hold to a recall.
[% END %]
diff --git a/t/db_dependent/Holds.t b/t/db_dependent/Holds.t index 2445ce88cc6..b1baba479c9 100755 --- a/t/db_dependent/Holds.t +++ b/t/db_dependent/Holds.t @@ -7,7 +7,7 @@ use t::lib::TestBuilder; use C4::Context; -use Test::More tests => 72; +use Test::More tests => 73; use Test::Exception; use MARC::Record; @@ -2117,7 +2117,10 @@ subtest 'ModReserve to convert a hold to a recall' => sub { my $category = $builder->build( { source => 'Category' } ); my $branch = $builder->build( { source => 'Branch' } )->{branchcode}; my $biblio = $builder->build_sample_biblio( { itemtype => 'DUMMY' } ); - my $item = $builder->build_sample_item( { library => $branch, biblionumber => $biblio->biblionumber } ); + my $itype = $builder->build( { source => 'Itemtype' } ); + my $item = + $builder->build_sample_item( + { library => $branch, biblionumber => $biblio->biblionumber, itype => $itype->{itemtype} } ); my $patron = Koha::Patron->new( { @@ -2143,7 +2146,7 @@ subtest 'ModReserve to convert a hold to a recall' => sub { t::lib::Mocks::mock_preference( "UseRecalls", 1 ); t::lib::Mocks::mock_userenv( { branchcode => $branch } ); - C4::Circulation::AddIssue( $patron2->unblessed, $item->barcode ); + C4::Circulation::AddIssue( $patron2, $item->barcode ); Koha::CirculationRules->set_rules( { -- 2.34.1