From e9cb0bbdca253beb167037b01f834f23151d7450 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Tue, 28 Jan 2025 12:35:15 +0000 Subject: [PATCH] Bug 39021: Fix badly formatted dropdown on patron account transactions page This patch makes minor markup changes in order for the "Email" menu item to be styled correctly after the Bootstrap upgrade. The patch also simplifies the submission of the form by removing unnecessary JS event handling. To test, apply the patch and locate a patron record to view. - Open the "Accounting" tab - Click "Create manual invoice" - Put a charge on the patron's account and click "Save and pay" - Pay the charge - Click "Transactions" - In the "Actions" column there should be a "Receipt" menu. - The "Email" item should be correctly formatted, matching the "Print" entry. - Clicking "Email" should result in the page refreshing, with the message "Receipt sent" at the top. - If you don't have email set up you can confirm that the message was queued by creating an SQL report: "SELECT * FROM `message_queue`" - The report should show the message with the receipt you emailed. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind Signed-off-by: Nick Clemens --- .../intranet-tmpl/prog/en/modules/members/boraccount.tt | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt index c57c5163e67..88eb5eb7a93 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt @@ -144,7 +144,7 @@ [% IF ( account.is_credit ) %] [% IF Koha.Preference('UseEmailReceipts') %] -
+
@@ -510,11 +510,6 @@ $("#discount").attr({ "value": (0).format_price(), "max": amountoutstanding, "min": 0 }); $("#discount").focus(); }); - - $(".receipt-email-action").on("click", function(e){ - e.preventDefault(); - return $(this).siblings('form').submit(); - }); }); [% END %] -- 2.39.5