From b8b1d46f4833e78fd7b62228e1cefeacb6d36b6f Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 12 Feb 2025 22:17:42 +0100 Subject: [PATCH] Buug 38944: Revert changes to t/00-testcritic.t Not sure what's happening here. Skipping it for now. t/00-testcritic.t .. 3246/? # Failed test 'done_testing() was already called at /usr/share/perl5/Test/Perl/Critic.pm line 105' # at t/00-testcritic.t line 22. t/00-testcritic.t .. All 3249 subtests passed Test Summary Report ------------------- t/00-testcritic.t (Wstat: 0 Tests: 3251 Failed: 2) Failed tests: 3250-3251 Parse errors: Plan (1..3249) must be at the beginning or end of the TAP output Bad plan. You planned 3249 tests but ran 3251. --- t/00-testcritic.t | 3 --- 1 file changed, 3 deletions(-) diff --git a/t/00-testcritic.t b/t/00-testcritic.t index 635d4d06ec2..99f529f145e 100755 --- a/t/00-testcritic.t +++ b/t/00-testcritic.t @@ -3,7 +3,6 @@ # This script can be used to run perlcritic on perl files in koha use Modern::Perl; -use Test::NoWarnings qw( had_no_warnings ); use Test::More; use English qw(-no_match_vars); @@ -17,5 +16,3 @@ if ($EVAL_ERROR) { Test::Perl::Critic->import( -profile => '.perlcriticrc' ); my @files = map { chomp; $_ } `git ls-tree -r HEAD --name-only`; # only files part of git all_critic_ok(@files); - -had_no_warnings; -- 2.34.1