From e8a11f7dfe3d45d2a5c5a6cfed7d0db63e947826 Mon Sep 17 00:00:00 2001 From: Pedro Amorim Date: Thu, 20 Feb 2025 11:40:22 +0000 Subject: [PATCH] Bug 32630: Update get_notice Make it consider the possibility of a patron not existing. This ensures that placing a request with partners does not error and works as expected even if the ILL request's borrowernumber is undef To test: 1) Run the test file before and after applying this patch: prove t/db_dependent/Koha/ILL/Requests.t To test (ILL request is kept after borrower is deleted): 1) Apply all patches except this one 2) Enable ILLModule and create an ILL request. 3) Add a type, valid cardnumber and library. 4) Delete the associated borrower. 5) Confirm the ILL request is still listed and shown as expected Continue test, confirm follow-up bug is fixed: 6) Click 'Place request with partners' 7) You get a ERR_TOO_MANY_REDIRECTS error 8) Apply this patch and restart plack. Repeat. 9) Confirm the place request with partners libraries page is shown correctly --- Koha/ILL/Request.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Koha/ILL/Request.pm b/Koha/ILL/Request.pm index 90035032e42..c57400cb03f 100644 --- a/Koha/ILL/Request.pm +++ b/Koha/ILL/Request.pm @@ -1905,7 +1905,7 @@ sub get_notice { letter_code => $params->{notice_code}, branchcode => $self->branchcode, message_transport_type => $params->{transport}, - lang => $self->patron->lang, + lang => $self->patron ? $self->patron->lang : undef, tables => { illrequests => $self->illrequest_id, borrowers => $self->borrowernumber, -- 2.39.5