From 699d703297232a9dcbf69cca43155ef38294cdf3 Mon Sep 17 00:00:00 2001 From: Aleisha Amohia Date: Thu, 31 Oct 2024 03:18:33 +0000 Subject: [PATCH] Bug 38307: Make overdue_notices.pl die quietly if no branches have overdue rules Content-Type: text/plain; charset=utf-8 If no patron categories require overdue notices, then there will be no overdue rules/status triggers. This isn't necessarily a bad thing and shouldn't be noisy. To test: 1. Go to Administration -> Patron categories 2. Set all your category types to have overdue notice required: No 3. Go to Tools -> Overdue notices/status triggers 4. Notice you're unable to set any overdue rules 5. Run the cronjob misc/cronjobs/overdue_notices.pl and notice the error about no overdue rules is printed 6. Apply the patch and restart services 7. Run the cronjob misc/cronjobs/overdue_notices.pl and notice the error is not printed 8. Run the cronjob misc/cronjobs/overdue_notices.pl --verbose and notice the error is printed Sponsored-by: Catalyst IT Signed-off-by: Imani Thomas Signed-off-by: Marcel de Rooy --- misc/cronjobs/overdue_notices.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl index 7830ad28c7..7d3fd8796d 100755 --- a/misc/cronjobs/overdue_notices.pl +++ b/misc/cronjobs/overdue_notices.pl @@ -364,7 +364,7 @@ if ($branchcount) { and warn "Found $branchcount $overduebranch_word with first message enabled: " . join( ', ', map { "'$_'" } @overduebranches ), "\n"; } else { - die 'No branches with active overduerules'; + $verbose and die 'No branches with active overduerules'; } if (@branchcodes) { -- 2.39.5