From c472487f239713ead9be6e4058e58fbe720edc8b Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 28 Nov 2024 16:57:21 +0100 Subject: [PATCH] Bug 26553: Replace KohaTable with kohaTable Signed-off-by: Lucas Gass JD Amended patch: replace wrong occurrences of "kohatable" with "kohaTable" Signed-off-by: Martin Renvoize --- .../prog/en/modules/acqui/acqui-home.tt | 3 +- .../prog/en/modules/acqui/duplicate_orders.tt | 5 +-- .../prog/en/modules/acqui/histsearch.tt | 10 +++-- .../prog/en/modules/acqui/lateorders.tt | 3 +- .../prog/en/modules/admin/aqbudgets.tt | 3 +- .../en/modules/admin/authorised_values.tt | 3 +- .../prog/en/modules/admin/currency.tt | 6 +-- .../prog/en/modules/admin/desks.tt | 3 +- .../prog/en/modules/admin/itemtypes.tt | 10 +++-- .../en/modules/admin/patron-attr-types.tt | 4 +- .../prog/en/modules/admin/smart-rules.tt | 3 +- .../prog/en/modules/catalogue/detail.tt | 29 ++++++++------ .../prog/en/modules/catalogue/issuehistory.tt | 14 ++++--- .../prog/en/modules/catalogue/itemsearch.tt | 3 +- .../prog/en/modules/cataloguing/addbooks.tt | 10 +++-- .../en/modules/cataloguing/z3950_search.tt | 18 ++++----- .../prog/en/modules/circ/overdue.tt | 12 +++--- .../prog/en/modules/circ/pendingreserves.tt | 19 +++++---- .../prog/en/modules/circ/reserveratios.tt | 23 ++++++----- .../prog/en/modules/circ/returns.tt | 18 +++++---- .../prog/en/modules/circ/view_holdsqueue.tt | 14 ++++--- .../prog/en/modules/circ/waitingreserves.tt | 35 +++++++++------- .../modules/course_reserves/course-details.tt | 12 +++--- .../course_reserves/course-reserves.tt | 12 +++--- .../prog/en/modules/members/boraccount.tt | 14 ++++--- .../prog/en/modules/members/holdshistory.tt | 12 +++--- .../prog/en/modules/members/housebound.tt | 3 +- .../en/modules/members/moremember-print.tt | 40 +++++++++++-------- .../prog/en/modules/members/pay.tt | 12 +++--- .../prog/en/modules/members/readingrec.tt | 13 +++--- .../prog/en/modules/patron_lists/list.tt | 10 +++-- .../prog/en/modules/plugins/plugins-home.tt | 3 +- .../intranet-tmpl/prog/en/modules/pos/pay.tt | 15 ++++--- .../en/modules/reports/catalogue_stats.tt | 13 +++--- .../modules/reports/guided_reports_start.tt | 19 ++++----- .../prog/en/modules/reports/itemslost.tt | 22 +++++----- .../en/modules/reports/orders_by_budget.tt | 10 +++-- .../prog/en/modules/reserve/request.tt | 12 +++--- .../en/modules/serials/subscription-detail.tt | 23 ++++++----- .../prog/en/modules/suggestion/suggestion.tt | 12 +++--- .../prog/en/modules/tools/inventory.tt | 3 +- .../prog/en/modules/tools/modborrowers.tt | 12 +++--- .../prog/en/modules/tools/upload.tt | 4 +- .../prog/js/cataloging_additem.js | 5 +-- koha-tmpl/intranet-tmpl/prog/js/categories.js | 3 +- koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 6 +-- koha-tmpl/intranet-tmpl/prog/js/holds.js | 3 +- .../intranet-tmpl/prog/js/ill-availability.js | 2 +- .../intranet-tmpl/prog/js/ill-batch-modal.js | 2 +- .../intranet-tmpl/prog/js/ill-batch-table.js | 3 +- koha-tmpl/intranet-tmpl/prog/js/letter.js | 5 +-- .../prog/js/marc_modification_templates.js | 4 +- .../intranet-tmpl/prog/js/pages/batchMod.js | 4 +- .../prog/js/pages/stockrotation.js | 8 ++-- .../intranet-tmpl/prog/js/restrictiontypes.js | 2 +- koha-tmpl/intranet-tmpl/prog/js/viewlog.js | 3 +- 56 files changed, 313 insertions(+), 261 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt index 76ac361d9b7..0f9857e9e48 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt @@ -206,13 +206,12 @@ [% INCLUDE 'datatables.inc' %] [% Asset.js("lib/jquery/plugins/treetable/jquery.treetable.js") | $raw %] [% Asset.js("js/acquisitions-menu.js") | $raw %] - [% INCLUDE 'columns_settings.inc' %] [% END %] [% INCLUDE 'datatables.inc' %] - [% INCLUDE 'columns_settings.inc' %] [% INCLUDE 'js-date-format.inc' %] [% Asset.js("lib/dayjs/plugin/isSameOrAfter.js") | $raw %] [% Asset.js("lib/dayjs/plugin/isSameOrBefore.js") | $raw %] @@ -2072,12 +2071,15 @@ [% IF Koha.Preference('AcquisitionDetails') %] var table_settings = [% TablesSettings.GetTableSettings('catalogue', 'detail', 'acquisitiondetails-table', 'json') | $raw %]; - var acquisitiondetails_table = KohaTable("orders", { - "dom": 'C<"top pager"ilpfB><"#filter_c">tr<"bottom pager"ip>', - "paginate": false, - "autoWidth": false, - "order": [[ 4, "desc" ]], - }, table_settings); + var acquisitiondetails_table = $("#orders").kohaTable( + { + dom: 'C<"top pager"ilpfB><"#filter_c">tr<"bottom pager"ip>', + paginate: false, + autoWidth: false, + order: [[4, "desc"]], + }, + table_settings + ); [% END %] [% IF suggestions.count %] @@ -2092,11 +2094,14 @@ [% IF ( reviews ) %] var comment_table_settings = [% TablesSettings.GetTableSettings('catalogue', 'detail', 'comments-table', 'json') | $raw %]; - var comments_table = KohaTable("comments_table", { - "paginate": false, - "autoWidth": false, - "order": [[ 2, "desc" ]], - }, comment_table_settings); + var comments_table = $("#comments_table").kohaTable( + { + paginate: false, + autoWidth: false, + order: [[2, "desc"]], + }, + comment_table_settings + ); [% END %] }); diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt index ca95717b7d0..409f57721b0 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt @@ -127,7 +127,6 @@ [% MACRO jsinclude BLOCK %] [% INCLUDE 'datatables.inc' %] - [% INCLUDE 'columns_settings.inc' %] [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt index c536d089ba1..cbfdfa733c4 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt @@ -375,7 +375,6 @@ [% MACRO jsinclude BLOCK %] [% INCLUDE 'calendar.inc' %] [% INCLUDE 'datatables.inc' %] - [% INCLUDE 'columns_settings.inc' %] [% INCLUDE 'select2.inc' %] [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt index 6282468516d..a9f97bb9f2c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt @@ -214,19 +214,24 @@ [% MACRO jsinclude BLOCK %] [% INCLUDE 'calendar.inc' %] [% INCLUDE 'datatables.inc' %] - [% INCLUDE 'columns_settings.inc' %] [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt index 5af5b9b8952..df0be32c04b 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt @@ -1466,7 +1466,6 @@ [% MACRO jsinclude BLOCK %] [% INCLUDE 'datatables.inc' %] - [% INCLUDE 'columns_settings.inc' %] [% INCLUDE 'calendar.inc' %] [% Asset.js("js/pages/circulation.js") | $raw %] [% Asset.js("js/modal_printer.js") | $raw %] @@ -1527,13 +1526,16 @@ Dopop('/cgi-bin/koha/recalls/recall_pickup_slip.pl?recall_id=[% recall_id | uri %]'); [% END %] - var returns_table = KohaTable("checkedintable", { - "searching":false, - "paginate":false, - "info": false, - "ordering":false, - "dom": '<"table_controls"B>rt', - }, table_settings); + var returns_table = $("#checkedintable").kohaTable( + { + searching: false, + paginate: false, + info: false, + ordering: false, + dom: '<"table_controls"B>rt', + }, + table_settings + ); $("#exemptcheck").change(function () { if (this.checked == true) { diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt index c7e0040cd12..76b457569f3 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt @@ -347,7 +347,6 @@ [% MACRO jsinclude BLOCK %] [% INCLUDE 'datatables.inc' %] - [% INCLUDE 'columns_settings.inc' %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt index 3f29fff5601..b3059e65abd 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt @@ -186,7 +186,6 @@ [% MACRO jsinclude BLOCK %] [% INCLUDE 'datatables.inc' %] - [% INCLUDE 'columns_settings.inc' %] [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt index e2bc47ae821..e33aa4ea5aa 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt @@ -430,7 +430,6 @@ [% MACRO jsinclude BLOCK %] [% INCLUDE 'datatables.inc' %] [% INCLUDE 'format_price.inc' %] - [% INCLUDE 'columns_settings.inc' %] [% INCLUDE 'str/members-menu.inc' %] [% Asset.js("js/members-menu.js") | $raw %] [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt index 10d6ead820c..da7b9fcdf53 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt @@ -417,14 +417,13 @@ [% MACRO jsinclude BLOCK %] [% INCLUDE 'calendar.inc' %] [% INCLUDE 'datatables.inc' %] - [% INCLUDE 'columns_settings.inc' %] [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt index 41e7e8b896b..9166f33f12c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt @@ -160,7 +160,6 @@ [% INCLUDE 'str/members-menu.inc' %] [% Asset.js("js/members-menu.js") | $raw %] [% INCLUDE 'datatables.inc' %] - [% INCLUDE 'columns_settings.inc' %] [% INCLUDE 'modals/checkout_renewals.inc' %] [% INCLUDE 'js-date-format.inc' %] [% INCLUDE 'js-patron-format.inc' %] @@ -168,15 +167,19 @@ [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt index 1536ac86732..55afc39ff05 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt @@ -1699,7 +1699,6 @@ [% INCLUDE 'calendar.inc' %] [% INCLUDE 'datatables.inc' %] [% IF ( saved1 ) %] - [% INCLUDE 'columns_settings.inc' %] [% Asset.js( "lib/jsdiff/jsdiff.min.js" ) | $raw %] [% END %] [% Asset.js( "lib/codemirror/codemirror.min.js" ) | $raw %] @@ -2153,15 +2152,17 @@ [% IF (saved1) %] var table_settings = [% TablesSettings.GetTableSettings( 'reports', 'saved-sql', 'table_reports', 'json' ) | $raw %]; - var rtable = KohaTable("table_reports", { - "autoWidth": false, - "pagingType": 'full', - "order": [[ 1, "asc" ]], - "language": { - "zeroRecords": _("No matching reports found") + var rtable = $("#table_reports").kohaTable( + { + autoWidth: false, + pagingType: "full", + order: [[1, "asc"]], + language: { + zeroRecords: _("No matching reports found"), + }, }, - - }, table_settings); + table_settings + ); let table_dt = rtable.DataTable(); $("#tabs a[data-bs-toggle='tab']").on("shown.bs.tab", function (e) { diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt index 36fccf9c8fc..02b37fcc959 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt @@ -193,23 +193,27 @@ [% MACRO jsinclude BLOCK %] [% INCLUDE 'datatables.inc' %] - [% INCLUDE 'columns_settings.inc' %]