From d26ea210b162b913efa1125d5b315dc759bce15a Mon Sep 17 00:00:00 2001
From: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Date: Fri, 21 Feb 2025 14:51:22 -0500
Subject: [PATCH] Bug 39185: Don't add select option if priority is 0

To test:
1. Place several holds on a biblio record
2. Check in items from that record and confirm some (but not all) of the
    holds
3. View the current holds on that record
4. Click on the drop-down to change the priority of a hold
--> Note that the drop-down contains one or more "0" options - one for
    each in-transit or waiting hold
5. Apply patch and refresh the page
6. Click on the drop-down again
--> The drop-down now contains the correct options
7. Use the drop-down and the "Update holds" button to change hold
    hold priorities a few times
--> Confirm that the priority is updated correctly

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
---
 koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
index c2d717a9fe..2d65e83dc1 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
@@ -61,7 +61,7 @@
                                     [% FOREACH priority IN all_priorities %]
                                         [% IF priority == this_priority %]
                                             <option value="[% priority | html %]" selected="selected">[% priority | html %]</option>
-                                        [% ELSE %]
+                                        [% ELSIF priority > 0 %]
                                             <option value="[% priority | html %]">[% priority | html %]</option>
                                         [% END %]
                                     [% END %]
-- 
2.47.1