From b0380b21c88c5a2649d129e31ea20a60fa33a449 Mon Sep 17 00:00:00 2001 From: Victor Grousset/tuxayo Date: Mon, 24 Feb 2025 05:41:50 +0100 Subject: [PATCH] Bug 39188: Fix ESLint by Updating "globals" node package According to the main dev of ESLint, we should add it to devDependencies because we are the ones calling globals from eslint.config.mjs: https://github.com/eslint/eslint/issues/19209#issuecomment-2518452107 Test plan: 1. run: eslint ./koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue 2. TypeError: Key "languageOptions": Key "globals": Global "AudioWorkletGlobalScope " has leading or trailing whitespace 3. :( 4. Apply patch 5. sudo yarn install --modules-folder /kohadevbox/node_modules 6. run: eslint ./koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue 7. eslint output a report about the issues found in the file 8. signoff :D --- package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/package.json b/package.json index eacf4b016e..7d3f59253b 100644 --- a/package.json +++ b/package.json @@ -80,6 +80,7 @@ "eslint-config-prettier": "^9.1.0", "eslint-plugin-prettier": "^5.1.3", "eslint-plugin-vue": "^9.29.0", + "globals": "^16.0.0", "gulp-tap": "^1.0.1", "html-webpack-plugin": "^5.5.0", "node-sass-tilde-importer": "^1.0.2", -- 2.48.1