From a4bb56ae4a3c87e01e8ef4da602494c233bee377 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Wed, 27 Feb 2013 08:46:56 -0500 Subject: [PATCH] [PASSED QA] Bug 9719 - Changing the rows per page on a custom report fails if it has user supplied parameters If you create an SQL report that includes one or more parameters, using the 'rows per page' pulldown does not work. Instead, it will prompt for the parameters again and shows the first page of output. Test Plan: 1) Create a new report from sql as follows: SELECT * FROM borrowers WHERE surname LIKE <> AND firstname LIKE <> 2) Run this report 3) Change the 'Rows per page' and click 'Update' 4) This should kick you back to the start where the report asks you for your parameters 5) Apply the patch 6) Repeat step 3, this time is should work correctly Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Works nicely now. All tests and QA script pass. --- .../en/modules/reports/guided_reports_start.tt | 6 +++++- reports/guided_reports.pl | 1 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt index cf38cbf..4cd0728 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt @@ -750,10 +750,14 @@ canned reports and writing custom SQL reports.

[% IF ( unlimited_total ) %]

Total number of rows matching the (unlimited) query is [% unlimited_total %].

[% END %]
[% sql |html %]
-
+ + [% FOREACH p IN sql_params %] + + [% END %] +