From 63e5978157ad60d5a5c78c58dbce219f9cf9e834 Mon Sep 17 00:00:00 2001 From: Aleisha Amohia Date: Mon, 20 Mar 2023 22:51:55 +0000 Subject: [PATCH] Bug 33260: Add view_generated_notices user permission Signed-off-by: Laura Escamilla Signed-off-by: kelly Signed-off-by: David Nind Signed-off-by: Martin Renvoize --- ...dd_tools_view_generated_notices_permission.pl | 16 ++++++++++++++++ .../data/mysql/mandatory/userpermissions.sql | 3 ++- .../prog/en/includes/permissions.inc | 3 +++ t/Koha/Auth/Permissions.t | 1 + 4 files changed, 22 insertions(+), 1 deletion(-) create mode 100644 installer/data/mysql/atomicupdate/bug_33260_-_add_tools_view_generated_notices_permission.pl diff --git a/installer/data/mysql/atomicupdate/bug_33260_-_add_tools_view_generated_notices_permission.pl b/installer/data/mysql/atomicupdate/bug_33260_-_add_tools_view_generated_notices_permission.pl new file mode 100644 index 00000000000..e2d9f58d9fb --- /dev/null +++ b/installer/data/mysql/atomicupdate/bug_33260_-_add_tools_view_generated_notices_permission.pl @@ -0,0 +1,16 @@ +use Modern::Perl; + +return { + bug_number => "33260", + description => "Show message queue on staff interface and make notices printable", + up => sub { + my ($args) = @_; + my ( $dbh, $out ) = @$args{qw(dbh out)}; + + $dbh->do( + q{ INSERT IGNORE INTO permissions (module_bit, code, description) VALUES (13, 'view_generated_notices', 'View and print generated notices') } + ); + + say $out "Added user permission view_generated_notices"; + }, +}; diff --git a/installer/data/mysql/mandatory/userpermissions.sql b/installer/data/mysql/mandatory/userpermissions.sql index 1d8b7d034f2..8c61ce09c36 100644 --- a/installer/data/mysql/mandatory/userpermissions.sql +++ b/installer/data/mysql/mandatory/userpermissions.sql @@ -101,6 +101,7 @@ INSERT INTO permissions (module_bit, code, description) VALUES (13, 'moderate_comments', 'Moderate patron comments'), (13, 'edit_notices', 'Define notices'), (13, 'edit_notice_status_triggers', 'Set notice/status triggers for overdue items'), + (13, 'view_generated_notices', 'View and print generated notices'), (13, 'edit_quotes', 'Edit quotes for quote-of-the-day feature'), (13, 'view_system_logs', 'Browse the system logs'), (13, 'inventory', 'Perform inventory (stocktaking) of your catalog'), @@ -164,4 +165,4 @@ INSERT INTO permissions (module_bit, code, description) VALUES (25, 'takepayment', 'Access the point of sale page and take payments'), (26, 'manage_problem_reports', 'Manage OPAC problem reports'), (27, 'manage_recalls', 'Manage recalls for patrons') -; +; \ No newline at end of file diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc index 4ca590e4b8d..82b2339acfe 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc @@ -377,6 +377,9 @@ [%- CASE 'edit_notices' -%] Define notices ([% name | html %]) + [%- CASE 'view_generated_notices' -%] + View and print generated notices + ([% name | html %]) [%- CASE 'edit_patrons' -%] Perform batch modification of patrons ([% name | html %]) diff --git a/t/Koha/Auth/Permissions.t b/t/Koha/Auth/Permissions.t index 108373cfb66..2b111d69c82 100755 --- a/t/Koha/Auth/Permissions.t +++ b/t/Koha/Auth/Permissions.t @@ -260,6 +260,7 @@ subtest 'superlibrarian tests' => sub { 'CAN_user_tools_edit_calendar' => 1, 'CAN_user_tools_edit_notice_status_triggers' => 1, 'CAN_user_tools_edit_notices' => 1, + 'CAN_user_tools_view_generated_notices' => 1, 'CAN_user_tools_edit_patrons' => 1, 'CAN_user_tools_edit_quotes' => 1, 'CAN_user_tools_export_catalog' => 1, -- 2.48.1