From 5e2dc71d28deb8160d1a1b58da3f4df6d5c2f812 Mon Sep 17 00:00:00 2001 From: Lucas Gass <lucas@bywatersolutions.com> Date: Fri, 20 Dec 2024 21:31:54 +0000 Subject: [PATCH] Bug 15461: Add stand alone shelving location column to holdings table Content-Type: text/plain; charset=utf-8 To test: 1. APPLY patch and restart_all 2. Go the detail page for some records and see the shelving location column. 3. Make sure the data looks correct 4. Try Table settings to make sure the column can be properly hidden NOTE: You cannot currently search the holdings table for AV descriptions, only the code. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- admin/columns_settings.yml | 6 +++++- .../html_helpers/tables/items/catalogue_detail.inc | 12 ++++++++++-- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml index 8377ba2f77..e2293a9930 100644 --- a/admin/columns_settings.yml +++ b/admin/columns_settings.yml @@ -436,6 +436,8 @@ modules: columnname: holdingbranch - columnname: homebranch + - + columnname: location - columnname: ccode - @@ -507,6 +509,8 @@ modules: columnname: holdingbranch - columnname: homebranch + - + columnname: location - columnname: ccode - @@ -2550,4 +2554,4 @@ modules: - columnname: actions cannot_be_toggled: 1 - cannot_be_modified: 1 + cannot_be_modified: 1 \ No newline at end of file diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc index 84451e0aa4..efb11922a9 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc @@ -17,6 +17,7 @@ [% IF ( item_level_itypes ) %]<th id="[% tab | html %]_itype" data-colname="itype">Item type</th>[% END %] <th id="[% tab | html %]_holdingbranch" data-colname="holdingbranch">Current library</th> <th id="[% tab | html %]_homebranch" data-colname="homebranch">Home library</th> + <th id="[% tab | html %]_loction" data-colname="location">Shelving location</th> <th id="[% tab | html %]_ccode" data-colname="ccode">Collection</th> [% IF Koha.Preference('EnableItemGroups') %] <th id="[% tab | html %]_item_group" data-colname="item_group">Item group</th> @@ -401,8 +402,15 @@ searchable: true, orderable: true, render: function (data, type, row, meta) { - let nodes = '<span class="homebranchdesc">%s</span>'.format(escape_str(row._strings.home_library_id ? row._strings.home_library_id.str : row.home_library_id)); - nodes += '<span class="shelvingloc">' + return escape_str(row._strings.home_library_id ? row._strings.home_library_id.str : row.home_library_id); + } + }, + { + data: "me.location", + searchable: true, + orderable: true, + render: function (data, type, row, meta) { + let nodes = '<span class="shelvingloc">'; [%# If permanent location is defined, show description or code and %] [%# display current location in parentheses. If not, display current location. %] [%# Note that permanent location is a code, and location may be an authval. %] -- 2.39.5