From 006b6ba57ebf823991285e1135bb4e866ea554fb Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Mon, 4 Dec 2023 14:38:48 +0000 Subject: [PATCH] Bug 33544: Link title in details to biblio This patch removes the biblio id column and instead adds the biblio link to the title field in the request details column when appropriate. Signed-off-by: Lisette Scheer --- admin/columns_settings.yml | 2 -- .../prog/en/includes/ill-list-table.inc | 1 - .../intranet-tmpl/prog/js/ill-list-table.js | 22 +++++++------------ 3 files changed, 8 insertions(+), 17 deletions(-) diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml index adf8da43806..e0e94bf2b71 100644 --- a/admin/columns_settings.yml +++ b/admin/columns_settings.yml @@ -1064,8 +1064,6 @@ modules: columnname: orderid - columnname: patron - - - columnname: biblio_id - columnname: library_branchname - diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc index abf1d1f15fa..c924d7281a8 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc @@ -13,7 +13,6 @@ Request type Order ID Patron - Bibliographic record ID Library Status Placed on diff --git a/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js b/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js index 84bac7ea965..fcd16e0bde4 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js +++ b/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js @@ -286,7 +286,14 @@ $(document).ready(function () { ) + ""; } - if (display_extended_attribute(row, "title") !== "") { + if (row.biblio_id !== null) { + display += + ' Title: ' + + $biblio_to_html(row.biblio, { link: 1 }) + + ""; + } else if ( + display_extended_attribute(row, "title") !== "" + ) { display += ' Title: ' + display_extended_attribute(row, "title") + @@ -364,19 +371,6 @@ $(document).ready(function () { : ""; }, }, - { - data: "biblio_id", - orderable: true, - render: function (data, type, row, meta) { - if (data === null) { - return ""; - } - return $biblio_to_html(row.biblio, { - biblio_id_only: 1, - link: 1, - }); - }, - }, { data: "library.name", orderable: true, -- 2.39.5