From f1f6bf535a592feff21d12bca356548691373f73 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 13 Mar 2025 09:47:27 +0100 Subject: [PATCH] Bug 39319: Make podcorrectness.t test controller and test perl files It only tested files within C4 and Koha directories. Now we test all the perl files that are in the git index. Test plan: 0. Do not apply those patches 1. prove xt/author/podcorrectness.t Notice "Tests=1208" meaning that 1208 files are tested 2. Apply this patch (not the second one) It fails, and more files are being tested (3254) xt/author/podcorrectness.t .. 1994/3254 xt/author/podcorrectness.t .. 2726/3254 # Looks like you failed 1 test of 3254. 3. Apply the second patch => It passes! --- xt/author/podcorrectness.t | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/xt/author/podcorrectness.t b/xt/author/podcorrectness.t index f1baf333fed..1f86f156106 100755 --- a/xt/author/podcorrectness.t +++ b/xt/author/podcorrectness.t @@ -1,5 +1,4 @@ #!/usr/bin/env perl -use Modern::Perl; =head2 podcorrectness.t @@ -8,16 +7,17 @@ correctness. It typically finds things like pod tags withouth blank lines immediately before or after them, unknown directives, or =over, =item, and =back in the wrong order. -You must have Test::Pod installed. - -One good way to run this is with C +One good way to run this is with C =cut +use Modern::Perl; use Test::More; -eval "use Test::Pod 1.00"; -plan skip_all => "Test::Pod 1.00 required for testing POD" if $@; -my @poddirs = qw( C4 Koha ); -all_pod_files_ok( all_pod_files(@poddirs) ); +use Test::Pod; + +my @files; +push @files, qx{git ls-files '*.pl' '*.PL' '*.pm' '*.t'}; +push @files, qx{git ls-files svc opac/svc}; # Files without extension +chomp for @files; +all_pod_files_ok(@files); -- 2.34.1