From 88e540f8d609e067eb360d352b19bd8e7ddcd14b Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 13 Mar 2025 16:28:11 +0100 Subject: [PATCH] Bug 39319: Fixes for Pod::Checker --- C4/InstallAuth.pm | 2 +- C4/SIP/SIPServer.pm | 10 +++++++--- Koha/Filter/MARC/EmbedSeeFromHeadings.pm | 1 + Koha/Filter/MARC/Null.pm | 1 + Koha/Notice/Templates.pm | 2 +- Koha/REST/V1/ERM/EUsage/CustomReports.pm | 2 +- Koha/SuggestionEngine/Plugin/AuthorityFile.pm | 1 + Koha/SuggestionEngine/Plugin/ExplodedTerms.pm | 1 + Koha/SuggestionEngine/Plugin/Null.pm | 1 + acqui/spent.pl | 2 +- opac/opac-ratings.pl | 2 +- xt/author/podcorrectness.t | 2 +- xt/yaml_valid.t | 1 + 13 files changed, 19 insertions(+), 9 deletions(-) diff --git a/C4/InstallAuth.pm b/C4/InstallAuth.pm index 27e612557c1..36261e1c617 100644 --- a/C4/InstallAuth.pm +++ b/C4/InstallAuth.pm @@ -70,7 +70,7 @@ been provided so that a users login information is passed along automatically. This gets loaded into the template. This package is different from C4::Auth in so far as C4::Auth uses many preferences which are supposed NOT to be obtainable when installing the database. - + As in C4::Auth, Authentication is based on cookies. =head1 FUNCTIONS diff --git a/C4/SIP/SIPServer.pm b/C4/SIP/SIPServer.pm index 608f664c433..8ddb01e20d2 100644 --- a/C4/SIP/SIPServer.pm +++ b/C4/SIP/SIPServer.pm @@ -1,5 +1,9 @@ #!/usr/bin/perl +=head1 NAME + C4::SIP::SIPServer +=cut + package C4::SIP::SIPServer; use strict; @@ -93,7 +97,7 @@ __PACKAGE__->run(@parms); # Server # -=head3 options +=head2 options As per Net::Server documentation, override "options" to provide your own custom options to the Net::Server* object. This allows us to use the Net::Server @@ -120,7 +124,7 @@ sub options { $template->{'custom_tcp_keepalive_intvl'} = \$prop->{'custom_tcp_keepalive_intvl'}; } -=head3 post_configure_hook +=head2 post_configure_hook As per Net::Server documentation, this method validates our custom configuration. @@ -148,7 +152,7 @@ sub post_configure_hook { } } -=head3 post_accept_hook +=head2 post_accept_hook This hook occurs after the client connection socket is created, which gives us an opportunity to enable support for TCP keepalives using the SO_KEEPALIVE diff --git a/Koha/Filter/MARC/EmbedSeeFromHeadings.pm b/Koha/Filter/MARC/EmbedSeeFromHeadings.pm index 2dac9aeb038..acbe305f29d 100644 --- a/Koha/Filter/MARC/EmbedSeeFromHeadings.pm +++ b/Koha/Filter/MARC/EmbedSeeFromHeadings.pm @@ -23,6 +23,7 @@ Koha::Filter::MARC::EmbedSeeFromHeadings - embeds see from headings into MARC fo =head1 SYNOPSIS +=cut =head1 DESCRIPTION diff --git a/Koha/Filter/MARC/Null.pm b/Koha/Filter/MARC/Null.pm index 8aa94327f62..7eae2c06daf 100644 --- a/Koha/Filter/MARC/Null.pm +++ b/Koha/Filter/MARC/Null.pm @@ -23,6 +23,7 @@ Koha::Filter::MARC::Null - an example filter that does nothing but allow us to r =head1 SYNOPSIS +=cut =head1 DESCRIPTION diff --git a/Koha/Notice/Templates.pm b/Koha/Notice/Templates.pm index f30d3190b3c..53ab3be01c1 100644 --- a/Koha/Notice/Templates.pm +++ b/Koha/Notice/Templates.pm @@ -33,7 +33,7 @@ Koha::Notice::Templates - Koha notice template Object set class, related to the =cut -=head3 +=head3 find_effective_template my $template = Koha::Notice::Templates->find_effective_template( { diff --git a/Koha/REST/V1/ERM/EUsage/CustomReports.pm b/Koha/REST/V1/ERM/EUsage/CustomReports.pm index 73b780ff3bd..cb3fc66fa10 100644 --- a/Koha/REST/V1/ERM/EUsage/CustomReports.pm +++ b/Koha/REST/V1/ERM/EUsage/CustomReports.pm @@ -678,7 +678,7 @@ sub _create_report_rows { } } -=head3 +=head3 _get_usage_total A method for summing the usage counts for a data object diff --git a/Koha/SuggestionEngine/Plugin/AuthorityFile.pm b/Koha/SuggestionEngine/Plugin/AuthorityFile.pm index 278a783124e..d58d8c3d11d 100644 --- a/Koha/SuggestionEngine/Plugin/AuthorityFile.pm +++ b/Koha/SuggestionEngine/Plugin/AuthorityFile.pm @@ -23,6 +23,7 @@ Koha::SuggestionEngine::Plugin::AuthorityFile - get suggestions from the authori =head1 SYNOPSIS +=cut =head1 DESCRIPTION diff --git a/Koha/SuggestionEngine/Plugin/ExplodedTerms.pm b/Koha/SuggestionEngine/Plugin/ExplodedTerms.pm index 3e704c4d098..a21deb25b10 100644 --- a/Koha/SuggestionEngine/Plugin/ExplodedTerms.pm +++ b/Koha/SuggestionEngine/Plugin/ExplodedTerms.pm @@ -23,6 +23,7 @@ Koha::SuggestionEngine::Plugin::ExplodedTerms - suggest searches for broader/nar =head1 SYNOPSIS +=cut =head1 DESCRIPTION diff --git a/Koha/SuggestionEngine/Plugin/Null.pm b/Koha/SuggestionEngine/Plugin/Null.pm index ba37fa0c607..06d22ff3932 100644 --- a/Koha/SuggestionEngine/Plugin/Null.pm +++ b/Koha/SuggestionEngine/Plugin/Null.pm @@ -23,6 +23,7 @@ Koha::SuggestionEngine::Plugin::Null - an example plugin that does nothing but a =head1 SYNOPSIS +=cut =head1 DESCRIPTION diff --git a/acqui/spent.pl b/acqui/spent.pl index 8ca58ad7585..374b6c6a8ba 100755 --- a/acqui/spent.pl +++ b/acqui/spent.pl @@ -21,7 +21,7 @@ =head1 NAME - acqui/spent.pl +acqui/spent.pl =head1 DESCRIPTION diff --git a/opac/opac-ratings.pl b/opac/opac-ratings.pl index 5b7b25fce25..1bd9411d272 100755 --- a/opac/opac-ratings.pl +++ b/opac/opac-ratings.pl @@ -17,7 +17,7 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -=head1 +=head1 SYNOPSIS A non-javascript method to add/modify a biblio's rating, called from opac-detail.pl diff --git a/xt/author/podcorrectness.t b/xt/author/podcorrectness.t index 1f86f156106..129a6979459 100755 --- a/xt/author/podcorrectness.t +++ b/xt/author/podcorrectness.t @@ -1,6 +1,6 @@ #!/usr/bin/env perl -=head2 podcorrectness.t +=head1 podcorrectness.t This test file checks all perl modules in the C4 directory for POD correctness. It typically finds things like pod tags withouth blank diff --git a/xt/yaml_valid.t b/xt/yaml_valid.t index d8b128498a6..f8a0c1cca95 100755 --- a/xt/yaml_valid.t +++ b/xt/yaml_valid.t @@ -48,6 +48,7 @@ yaml_valid.t =head1 DESCRIPTION +=cut =head1 USAGE -- 2.34.1