From 1718f19d76a24b6dffcb089774abf5ae2f5d2ac4 Mon Sep 17 00:00:00 2001 From: Matt Blenkinsop Date: Wed, 2 Oct 2024 09:59:30 +0000 Subject: [PATCH] Bug 38061: Add item column to serial collections table This patch adds a column to the table to link to the item Test plan: 1) Add a new subscription to a serial record (with the option 'create an item record' selected) 2) Receive several issues and create the linked items 3) Navigate to the serials collection table 4) There should be a column for the linked item 5) Click on one of the links, it should display the item Signed-off-by: Nathalie --- C4/Serials.pm | 10 +++++++--- .../prog/en/modules/serials/serials-collection.tt | 4 ++++ serials/serials-collection.pl | 4 ++-- 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/C4/Serials.pm b/C4/Serials.pm index 39853a878bb..89e1a323628 100644 --- a/C4/Serials.pm +++ b/C4/Serials.pm @@ -354,13 +354,13 @@ sub GetFullSubscription { =head2 PrepareSerialsData - $array_ref = PrepareSerialsData($serialinfomation) - where serialinformation is a hashref array + $array_ref = PrepareSerialsData($serialinfomation, $add_itemnumbers) + where serialinformation is a hashref array and add_itemnumbers is a boolean =cut sub PrepareSerialsData { - my ($lines) = @_; + my ( $lines, $add_itemnumbers ) = @_; return unless ($lines); @@ -376,6 +376,10 @@ sub PrepareSerialsData { if ( grep { $_ == $subs->{status} } ( EXPECTED, LATE, MISSING_STATUSES, CLAIMED ) ) { $subs->{"checked"} = 1; } + if ($add_itemnumbers) { + my $serialitem = Koha::Serial::Items->find( { serialid => $subs->{'serialid'} } ); + $subs->{"itemnumber"} = $serialitem->itemnumber if $serialitem; + } if ( $subs->{'year'} && $subs->{'year'} ne "" ) { $year = $subs->{'year'}; diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt index 67c39806aae..b6946056996 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt @@ -232,6 +232,7 @@ Number Status Notes + Linked item Library [% IF ( routing ) %] Routing @@ -311,6 +312,9 @@ [% INCLUDE 'serial-status.inc' serial = serial %] [% serial.notes | html %] + + [% serial.itemnumber | html %] + [% Branches.GetName( serial.branchcode ) | html %] [% IF ( routing ) %] diff --git a/serials/serials-collection.pl b/serials/serials-collection.pl index eccb80cbf5f..74a75c78c77 100755 --- a/serials/serials-collection.pl +++ b/serials/serials-collection.pl @@ -175,7 +175,7 @@ if (@subscriptionid) { output_and_exit( $query, $cookie, $template, 'unknown_subscription' ) unless @subscriptioninformation; $template->param( closed => $closed ); - $subscriptions = PrepareSerialsData( \@subscriptioninformation ); + $subscriptions = PrepareSerialsData( \@subscriptioninformation, 1 ); $subscriptioncount = CountSubscriptionFromBiblionumber( $subscriptiondescs->[0]{'biblionumber'} ); } else { $subscriptiondescs = GetSubscriptionsFromBiblionumber($biblionumber); @@ -186,7 +186,7 @@ if (@subscriptionid) { $s->{numberpattern} = $numberpattern; } my $subscriptioninformation = GetFullSubscriptionsFromBiblionumber($biblionumber); - $subscriptions = PrepareSerialsData($subscriptioninformation); + $subscriptions = PrepareSerialsData( $subscriptioninformation, 1 ); } my $title = $subscriptiondescs->[0]{bibliotitle}; -- 2.48.1