From dbe71c0bf6877d3fea4964a63732191b8d008c06 Mon Sep 17 00:00:00 2001 From: nina martinez Date: Wed, 19 Mar 2025 17:41:18 +0100 Subject: [PATCH] Remove the input size attributes and replace it with css style Test plan : 1- Verify that there are no size attributes in the input tags on the opac pages 2- Verify that the input design is still coherent 3- if that is the case, the test succeeds --- .../opac-tmpl/bootstrap/css/src/opac.scss | 27 +++++++++++++++++ .../en/modules/opac-addbybiblionumber.tt | 2 +- .../bootstrap/en/modules/opac-advsearch.tt | 2 +- .../bootstrap/en/modules/opac-auth.tt | 4 +-- .../bootstrap/en/modules/opac-memberentry.tt | 15 ++++------ .../bootstrap/en/modules/opac-passwd.tt | 6 ++-- .../en/modules/opac-password-recovery.tt | 8 ++--- .../bootstrap/en/modules/opac-recall.tt | 2 +- .../modules/opac-registration-confirmation.tt | 8 ++--- .../en/modules/opac-request-article.tt | 30 +++++++++---------- .../bootstrap/en/modules/opac-reserve.tt | 2 -- .../en/modules/opac-reset-password.tt | 8 ++--- .../en/modules/opac-sendbasketform.tt | 2 +- .../en/modules/opac-sendshelfform.tt | 2 +- .../bootstrap/en/modules/opac-shareshelf.tt | 2 +- .../bootstrap/en/modules/opac-suggestions.tt | 12 ++++---- .../bootstrap/en/modules/opac-tags.tt | 2 +- .../bootstrap/en/modules/opac-tags_subject.tt | 2 +- .../bootstrap/en/modules/opac-user.tt | 2 +- 19 files changed, 80 insertions(+), 58 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss index 5f182f644a..a489bce1c9 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss +++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss @@ -2981,4 +2981,31 @@ fieldset.brief label.show-password-toggle-label { padding: 0; } +input[name="limit-yr"]{ + width: 100%; +} + +input[name="borrower_streetnumber"],[name="borrower_B_streetnumber"],[name="quantity"],[name="number"]{ + width: 5%; +} + +input[name="copyrightdate"]{ + width: 10%; +} + +input[name="limit"]{ + width: 70px; +} + +input[name="newvirtualshelf"]{ + width: 20%; +} + +input[name="invite_address"],[id="title_article"],[id="author_article"],[name="volume"],[name="issue"],[name="date"],[name="pages"],[name="chapters"],[name="patron_notes"]{ + width: 25%; +} + +input[name="title_filter"]{ + width: 300px; +} @import "responsive"; diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-addbybiblionumber.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-addbybiblionumber.tt index bce9384a2d..81a53c5659 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-addbybiblionumber.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-addbybiblionumber.tt @@ -97,7 +97,7 @@
Add to a new list: - + +
For example: 1999-2001. You could also use "-1987" for everything published in and before 1987 or "2008-" for everything published in 2008 and after.
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt index 5414b9e6ef..c4a8b2e99e 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt @@ -248,11 +248,11 @@ [% END %]
[% PROCESS login_label for="userid" %] - +
- +
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt index c86f9f39e1..e9ba1db4e9 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt @@ -16,7 +16,7 @@
  • - +
    Required
  • [% END %] @@ -26,7 +26,7 @@
  • - +
    Required
  • [% END %] @@ -243,7 +243,6 @@ type="text" id="borrower_cardnumber" name="borrower_cardnumber" - size="20" value="[% borrower.cardnumber | html %]" minlength="[% minlength_cardnumber | html %]" maxlength="[% maxlength_cardnumber | html %]" @@ -256,7 +255,6 @@ type="text" id="borrower_cardnumber" name="borrower_cardnumber" - size="20" value="[% borrower.cardnumber | html %]" minlength="[% minlength_cardnumber | html %]" maxlength="[% maxlength_cardnumber | html %]" @@ -269,7 +267,6 @@ type="text" id="borrower_cardnumber" name="borrower_cardnumber" - size="20" value="[% borrower.cardnumber | html %]" maxlength="[% maxlength_cardnumber | html %]" class="[% required.cardnumber | html %]" @@ -277,7 +274,7 @@
    Required
    Card number can be up to [% maxlength_cardnumber | html %] characters.
    [% ELSE %] - +
    Required
    There is no minimum or maximum character length.
    [% END %] @@ -435,7 +432,7 @@
  • - +
    Required
  • @@ -1080,9 +1077,9 @@ [% ELSE %] [% IF ( pa.type.is_date && pa.type.mandatory ) %] - + [% ELSIF ( pa.type.is_date && !pa.type.mandatory ) %] - + [% ELSE %] [% END %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt index ed48620c33..716b58f53f 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt @@ -78,15 +78,15 @@ [% END %]
    - +
    - +
    - +
    diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt index 5b7d49d8cd..fb7a8f2ec3 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt @@ -133,12 +133,12 @@
    [% PROCESS login_label for="username" %] - +
    - +
    @@ -162,12 +162,12 @@ [% END %]
    - +
    - +
    diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recall.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recall.tt index 517a32f871..688a4149b1 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recall.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recall.tt @@ -81,7 +81,7 @@
  • - + [% INCLUDE 'date-format.inc' %]
  • diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt index b6a5fa090c..07b632048f 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt @@ -110,15 +110,15 @@ Log in to your account: [% PROCESS login_label for="userid" %] [% IF Koha.Preference('PatronSelfRegistrationPrefillForm') %] - + [% ELSE %] - + [% END %] [% IF Koha.Preference('PatronSelfRegistrationPrefillForm') %] - + [% ELSE %] - + [% END %]
    diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt index 890ba9d95f..911654ec09 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt @@ -70,55 +70,55 @@
  • [% IF mandatory_fields.search('title') %] - +
    Required
    [% ELSE %] - + [% END %]
  • [% IF mandatory_fields.search('author') %] - +
    Required
    [% ELSE %] - + [% END %]
  • [% IF mandatory_fields.search('volume') %] - +
    Required
    [% ELSE %] - + [% END %]
  • [% IF mandatory_fields.search('issue') %] - +
    Required
    [% ELSE %] - + [% END %]
  • [% IF mandatory_fields.search('date') %] - +
    Required
    [% ELSE %] - + [% END %]
  • @@ -130,28 +130,28 @@
  • [% IF mandatory_fields.search('pages') %] - +
    Required
    [% ELSE %] - + [% END %]
  • [% IF mandatory_fields.search('chapters') %] - +
    Required
    [% ELSE %] - + [% END %]
  • - +
  • diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt index b8c9b85aa0..b500cfbc51 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt @@ -296,7 +296,6 @@ id="from[% bibitemloo.biblionumber | html %]" data-start_for="to[% bibitemloo.biblionumber | html %]" data-flatpickr-futureinclusive="true" - size="10" class="flatpickr holddatefrom" value="[% KohaDates.datetime_from_string | $KohaDates dateformat => 'iso' %]" /> @@ -311,7 +310,6 @@ type="text" name="expiration_date_[% bibitemloo.biblionumber | html %]" id="to[% bibitemloo.biblionumber | html %]" - size="10" data-flatpickr-future="true" class="flatpickr futuredate" /> diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reset-password.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reset-password.tt index 7721bbfd7a..7721012f1c 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reset-password.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reset-password.tt @@ -79,19 +79,19 @@
    [% PROCESS login_label for="userid" %] - +
    - +
    - +
    - +
    diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasketform.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasketform.tt index d63b7f2dd1..e6656d14a5 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasketform.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasketform.tt @@ -37,7 +37,7 @@

    Sending your cart

    - + diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelfform.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelfform.tt index 0b67a02765..62c9280d65 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelfform.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelfform.tt @@ -36,7 +36,7 @@

    Sending your list

    - + diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt index 4da6ce2c04..7d3c761542 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt @@ -85,7 +85,7 @@
  • [% shelfname | html %]
  • - +
  • diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt index 9587f799fc..b0c3949dac 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt @@ -94,7 +94,7 @@ [% IF Koha.Preference( 'OPACSuggestionAutoFill' ) %]
  • - +
  • [% END %]
  • @@ -133,12 +133,12 @@ [% copyrightdate | html %] [% ELSIF ( copyrightdate_required ) %] - +
    Required
    Copyright or publication year, for example: 2022 [% ELSE %] - + Copyright or publication year, for example: 2022 [% END %] @@ -208,11 +208,11 @@
  • [% IF ( quantity_required ) %] - +
    Required
    [% ELSE %] - + [% END %]
  • [% END %] @@ -357,7 +357,7 @@
    - +
    [% IF Koha.Preference( 'OPACViewOthersSuggestions' ) %] [% IF loggedinusername %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt index c6a6b1fc77..8fc751a5cb 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt @@ -118,7 +118,7 @@
    - +
    diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags_subject.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags_subject.tt index 7c5b0ddc78..7963033f8f 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags_subject.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags_subject.tt @@ -38,7 +38,7 @@
    Show
    -

    up to subjects

    +

    up to subjects

    diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt index 438878a6f1..3254809a77 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt @@ -1048,7 +1048,7 @@
    - + [% INCLUDE 'date-format.inc' %]

    Clear date to suspend indefinitely

    -- 2.43.0