From 1622a2a9e4b02d1b79cfaf13d3da713e85342d38 Mon Sep 17 00:00:00 2001 From: Andreas Roussos Date: Mon, 31 Mar 2025 14:17:42 +0000 Subject: [PATCH] Bug 39501: add "value=" attributes to the HTML select element In the current main branch, when linking authorities with other authorities, if you select a relationship you no longer get the associated letter (i.e. the "relationship code") copied to the appropriate subfield. Rather, the whole description gets copied. This patch fixes that. Test plan: 0) [PREREQUISITES in order for the authority finder plugin to come up] a) You must have at least one authority type besides the 'Default'. b) View the MARC structure of the 'Default' auth type, then click on 'Actions->Subfields' for tag 500; click on 'Edit subfields'. Select the subfield 'a' tab, then pick an auth type from the 'Thesaurus:' dropdown menu; click 'Save changes' at the top. 1) In the Staff client, go to Authorities, then click 'New Authority' and pick the 'Default' authority type (or edit an existing auth). 2) When the authority editor comes up, go to tag 500 and expand it. 3) Click on the ellipsis (...) next to subfield $a. 4) When the authority finder comes up, search for an authority, pick a relator code from the 'Special relationship:' dropdown, and then click on the 'Choose' button for one of the authorities you found. 5) Notice that the whole description for the relationship you selected gets copied (instead of just the single letter relationship code). 6) Apply this patch. 7) Repeat steps 1-4. Notice that, this time, only the relationship code gets copied over. --- .../prog/en/includes/auth-finder-search.inc | 54 +++++++++---------- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/auth-finder-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/auth-finder-search.inc index 0c5965a250..d3bd1d9be2 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/auth-finder-search.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/auth-finder-search.inc @@ -153,34 +153,34 @@ [% selected=relationship | html %] [% IF Koha.Preference('marcflavour') == 'MARC21' %] - - - - - - - - - - + + + + + + + + + + [% ELSIF Koha.Preference('marcflavour') == 'UNIMARC' %] - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + [% END %] -- 2.39.5