From dae3d1c784d1683eaa1e38ee60bbdbd111bdad5f Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 18 Mar 2025 16:20:28 +0100 Subject: [PATCH] Bug 39368: Remove warnings from t::lib::Mocks::Zebra because of statement after exec we get: # Previous test 1217 'POD coverage for t/lib/Mocks/Logger.pm' # Statement unlikely to be reached at /kohadevbox/koha/t/lib/Mocks/Zebra.pm line 119. # at /kohadevbox/koha/t/lib/Mocks/Zebra.pm line 119. # require t/lib/Mocks/Zebra.pm called at (eval 4894) line 1 # eval ' require t::lib::Mocks::Zebra ' called at /usr/share/perl5/Pod/Coverage.pm line 308 # Pod::Coverage::_get_syms(Pod::Coverage=HASH(0x569d3a0bbf50), "t::lib::Mocks::Zebra") called at /usr/share/perl5/Pod/Coverage.pm line 152 # Pod::Coverage::coverage(Pod::Coverage=HASH(0x569d3a0bbf50)) called at /usr/share/perl5/Pod/Coverage.pm line 209 # Pod::Coverage::naked(Pod::Coverage=HASH(0x569d3a0bbf50)) called at xt/author/pod_coverage.t line 40 # main::check_pod_coverage("t/lib/Mocks/Zebra.pm") called at xt/author/pod_coverage.t line 30 Test plan: Run `prove xt/author/pod_coverage.t` and confirm that the tests pass with this patch applied. Also confirm that t/db_dependent/www/search_utf8.t still passes Note that xt/author/pod_coverage.t is coming from bug 39367. Signed-off-by: Magnus Enger Tested on top of bug 39367. Patch makes the mentioned tests pass. --- t/lib/Mocks/Zebra.pm | 2 -- 1 file changed, 2 deletions(-) diff --git a/t/lib/Mocks/Zebra.pm b/t/lib/Mocks/Zebra.pm index a4f88b40c2..9e1203fa61 100644 --- a/t/lib/Mocks/Zebra.pm +++ b/t/lib/Mocks/Zebra.pm @@ -95,7 +95,6 @@ sub launch_zebra { my $zebra_pid = fork(); if ( $zebra_pid == 0 ) { exec("zebrasrv -f $koha_conf -v none,request -l $datadir/zebra.log"); - exit; } sleep(1); $self->{zebra_pid} = $zebra_pid; @@ -116,7 +115,6 @@ sub launch_indexer { if ( $indexer_pid == 0 ) { exec("$rebuild_zebra -daemon -sleep 5"); - exit; } sleep(1); $self->{indexer_pid} = $indexer_pid; -- 2.34.1