From 4ecf46e52ff81825b0836e2f65c6a2cdcbfe32d1 Mon Sep 17 00:00:00 2001 From: Pedro Amorim Date: Tue, 25 Mar 2025 13:27:13 +0000 Subject: [PATCH] Bug 39446: Show both status and status_alias If a request has a status_alias and that status_alias does not have a lib_opac defined, it'll show as an empty status on the OPAC. Staff UI always shows the request's status and adds the status_alias only if that is defined. The same should happen on the OPAC. To test: 1) Enabled ILLModule 2) Create a new ILL request, visit: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Add '42' on the cardnumber. Pick any library. Click 'Create'. 4) Add a new 'status_alias' entry, visit the authorized values page: http://localhost:8081/cgi-bin/koha/admin/authorised_values.pl 5) Search for 'ill_'. Pick 'ILL_STATUS_ALIAS'. Click 'Add a new authorized value'. 6) Enter the 'Authorized value' of 'test', and 'Description' of 'test'. Click 'Save'. 7) Visit the previously created ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?op=illview&illrequest_id=1 8) Click 'Edit request' from the top toolbar. 9) On the 'Status' dropdown, pick 'test'. Click 'Submit'. 10) Visit the ILL on the OPAC: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl 11) Notice the 'status' column is empty. Click the 'View', notice the 'status' entry is empty. 12) Apply patch. Repeat Signed-off-by: David Nind --- .../bootstrap/en/modules/opac-illrequests.tt | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt index b3a5bfad6c..02cbcfd2ce 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt @@ -155,7 +155,12 @@ [% IF request.metadata.Title %][% request.metadata.Title | html %][% ELSE %]N/A[% END %] [% request.backend | html %] [% IF type %][% type | html %][% ELSE %]N/A[% END %] - [% request.status_alias ? request.statusalias.lib_opac : request.capabilities.$status.name | html %] + + [% request.capabilities.$status.name | html %] + [% IF request.status_alias && request.statusalias.lib_opac %] + ([% request.statusalias.lib_opac | html %]) + [% END %] + [% request.placed | $KohaDates %] [% request.updated | $KohaDates %] @@ -195,7 +200,10 @@
  • - [% request.status_alias ? request.statusalias.lib_opac : request.capabilities.$status.name | html %] + [% request.capabilities.$status.name | html %] + [% IF request.status_alias && request.statusalias.lib_opac %] + ([% request.statusalias.lib_opac | html %]) + [% END %]
  • -- 2.39.5