From 10434705f5f7af9a7e389db6a982c81a20cea4aa Mon Sep 17 00:00:00 2001 From: Andrew Auld Date: Thu, 3 Apr 2025 10:34:47 +0000 Subject: [PATCH] Bug 39543: Remove duplicated code in agreements controlling licence error message Test plan 1) Enable ERMModule sys pref 2) Add an agreement record 3) Add two licence records 4) Edit the agreement record and associate both license records to the agreement 5) Try to set both licenses to status 'controlling' 6) Note error modal duplicates the error message 'Only one controlling license is allowed' 7) Apply the patch, run yarn js:build and then hard refresh the browser 8) Repeat steps 1 to 5 and enjoy the single error message! --- .../prog/js/vue/components/ERM/AgreementsFormAdd.vue | 9 --------- 1 file changed, 9 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue index 643bb0acc4..3b4412430a 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue +++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue @@ -292,15 +292,6 @@ export default { ); } - if ( - agreement_licenses.filter(al => al.status == "controlling") - .length > 1 - ) { - errors.push( - this.$__("Only one controlling license is allowed") - ); - } - let documents_with_uploaded_files = agreement.documents.filter( doc => typeof doc.file_content !== "undefined" ); -- 2.39.5