From 8c4e2415ee870d7a96d8bf1b20316eaf11d04443 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Fri, 4 Apr 2025 09:20:57 +0000 Subject: [PATCH] Bug 39561: Allow users with fast_cataloging to continue after duplicate is found This patch adds the fast_cataloging permission to those checked when a duplicate is found Additionally, the barcode was missing from the duplicate check and is now added to be passed forward To test: 1 - Create or choose a borrower and grant permissions: catalogue circulate borrowers: list_borrowers editcatalogue: fast_cataloguing 2 - Log in as that patron 3 - Search for another borrower and go to checkout screen 4 - Enter random string as barcode to checkout 5 - Item is not found, click to fast catalogue 6 - In the editor type into 245$a 'Perl best practices' - or another title that exists in your system 7 - Get a notice of duplicate with options: Yes: View existing items No, save as new record 8 - Clicking 'Yes' will take you to the record details page - you cannot add an item because record is not FA framework 9 - You can click 'back' to return to the messages 10 - Clicking 'No' will create a new record and take you to the details page - you can add an item (Edit->manage items) but barcode has been dropped 11 - Apply patch 12 - Repeate 3-6 13 - You now get options: Yes: View existing items (you cannot add items to an existing record) No, save as new record 14 - 'Yes' will take you to details view 15 - Click back 16 - 'No' will take you to the edit items screen and populate the barcode 17 - Saving the item should return you to patron and issue item 18 - Repeat again with a staff patron with full permissions and confirm saying 'Yes' completes the fast catalogin workflow as expected --- .../prog/en/modules/cataloguing/addbiblio.tt | 21 ++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt index ad4d899fa63..83cbed751d5 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt @@ -861,9 +861,21 @@ > [% IF ( CAN_user_editcatalogue_edit_items ) %]
+ [% IF ( circborrowernumber ) # It is possible we have come from fast cataloging - include the fields %] + + + + + + [% END %]
+ [% ELSIF ( circborrowernumber ) # Coming from fast cataloging %] +
+ + +
[% ELSE %]
@@ -871,7 +883,14 @@
[% END %]
- [% IF ( CAN_user_editcatalogue_edit_items ) %] + [% IF ( CAN_user_editcatalogue_edit_items || CAN_user_editcatalogue_fast_cataloging ) %] + [% IF ( circborrowernumber ) # It is possible we have come from fast cataloging - include the fields %] + + + + + + [% END %] [% ELSE %] -- 2.39.5