From ac52ce09c86d6c2f13108368ce369da57029197d Mon Sep 17 00:00:00 2001 From: Emily Lamancusa Date: Thu, 20 Mar 2025 08:34:25 -0400 Subject: [PATCH] Bug 38842: (follow-up) Fix TT filters in modal_wrapper Use html filters for most of the parameter variables, when possible. The following parameters do need to be used raw, as they are expected to contain HTML code or complete url strings: modal_action modal_custom_confirm modal_print_url modal_custom_utility_button modal_custom_deny modal_footer_append If the caller includes any inputs from elsewhere in the above parameters, the caller must filter those inputs using the appropriate TT filter. This patch also adjusts the handling of header data so that only plain text should be passed. Signed-off-by: Baptiste Wojtkowski Signed-off-by: Paul Derscheid --- .../prog/en/includes/html_helpers.inc | 42 ++++++++++--------- .../prog/en/modules/circ/returns.tt | 2 +- 2 files changed, 23 insertions(+), 21 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc index 17863d6b0b..012d0da641 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc @@ -630,28 +630,30 @@ [% END %] [% BLOCK modal_wrapper %] -