Bugzilla – Attachment 18087 Details for
Bug 10191
2 option tags are not closed in unimarc_field_115a.tt and unimarc_field_116.tt
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 10191: Close 2 option tags in unimarc_field_115a.tt and unimarc_field_116.tt
PASSED-QA-Bug-10191-Close-2-option-tags-in-unimarc.patch (text/plain), 2.77 KB, created by
Katrin Fischer
on 2013-05-12 08:56:09 UTC
(
hide
)
Description:
[PASSED QA] Bug 10191: Close 2 option tags in unimarc_field_115a.tt and unimarc_field_116.tt
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-05-12 08:56:09 UTC
Size:
2.77 KB
patch
obsolete
>From 7cb064f7935372e976bb3578e6ffd0a03189e390 Mon Sep 17 00:00:00 2001 >From: Mathieu Saby <mathieu.saby@univ-rennes2.fr> >Date: Sat, 4 May 2013 11:31:24 +0200 >Subject: [PATCH] [PASSED QA] Bug 10191: Close 2 option tags in > unimarc_field_115a.tt and unimarc_field_116.tt > >This patch close 2 option tags in unimarc_field_115a.tt and unimarc_field_116.tt. > >To test : >- in a UNIMARC Koha instance, edit a record >- open the plugin for 115a subfield >- check the "Form of release - visual projection, motion picture" option > list is correct, especially the value "other film type" >- open the plugin for 116 field >- check the "Technique (prints) 2" option list is correct, especially > the value "lithography" > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >I did not test this in Koha, but it's a simple change of one character >which I'm comfortable with signing off on. > >I don't know if this counts as a string change or not, since the string >was previously mixed with a malformed tag. > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Passes tests and fixes an obvious problem in the HTML. >I checked the po files - currently the strings appear as: >"other film type/option> %s " > >So in theory it's possible to translate them correctly even >if the standard templates now are not correct. >Probably has to wait for 3.14. >--- > .../value_builder/unimarc_field_115a.tt | 2 +- > .../cataloguing/value_builder/unimarc_field_116.tt | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_115a.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_115a.tt >index f59d96a..4f64137 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_115a.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_115a.tt >@@ -390,7 +390,7 @@ > [% END %] > > [% IF ( f7d ) %] >- <option value="d" selected="selected">other film type/option> >+ <option value="d" selected="selected">other film type</option> > [% ELSE %] > <option value="d">other film type</option> > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_116.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_116.tt >index 0adcf6c..bef84e9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_116.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_116.tt >@@ -1146,7 +1146,7 @@ > > [% END %] > [% IF ( f9bi ) %] >- <option value="bi" selected="selected">lithography/option> >+ <option value="bi" selected="selected">lithography</option> > [% ELSE %] > <option value="bi">lithography</option> > >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10191
:
17946
|
18047
| 18087