From e662f428278401d8afb8cee6cc150d0017e3add7 Mon Sep 17 00:00:00 2001 From: David Cook Date: Mon, 14 Apr 2025 07:07:37 +0000 Subject: [PATCH] Bug 39623: Remove "install" target's dependency on "all" target This change removes the install target's dependency on "all". There is no clear reason why "install" would need to depend on all other build targets. After you remove this dependency, running "make" and "make install" work the way you'd expect them to work. "make" does the build and "make install" does the install. Test plan: 0. DO NOT APPLY THE PATCH YET! 1. Setup intall target sudo mkdir /opt/koha sudo chown kohadev-koha /opt/koha 2. Clean build env rm -rf blib Makefile /opt/koha/* 3. perl Makefile.PL Installation mode (dev, single, standard) [standard] single Please specify the directory in which to install Koha [/var/lib/koha/kohadev/koha] /opt/koha NOTE: Otherwise accept all defaults 4. make NOTE: build-resources.PL is run and the blib directory is populated 5. make install NOTE: build-resources.PL is run and the blib directory is populated and the built files are installed to /opt/koha 6. Apply the patch now 7. mv /opt/koha /opt/koha.bak 8. Re-setup install target sudo mkdir /opt/koha sudo chown kohadev-koha /opt/koha 9. Clean build env rm -rf blib Makefile /opt/koha/* 10. perl Makefile.PL Installation mode (dev, single, standard) [standard] single Please specify the directory in which to install Koha [/var/lib/koha/kohadev/koha] /opt/koha NOTE: Otherwise accept all defaults 11. make NOTE: build-resources.PL is run and the blib directory is populated 12. make install NOTE: Only the install step is run 13. diff -r /opt/koha /opt/koha.bak 14. Note that there are no differences between the two directories Signed-off-by: Paul Derscheid --- Makefile.PL | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.PL b/Makefile.PL index f5e0525d44..6a2ee4a333 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -1770,7 +1770,7 @@ KOHA_DEST_$key = $target_directories->{$key} ) unless exists $skip_directories->{$key}; } $install .= qq( -install :: all install_koha set_koha_ownership set_koha_permissions warn_koha_env_vars +install :: install_koha set_koha_ownership set_koha_permissions warn_koha_env_vars \t\$(NOECHO) \$(NOOP) ); $install .= "install_koha ::\n"; -- 2.39.5