From 1852feacbeba2a260e944301f043b97433513953 Mon Sep 17 00:00:00 2001 From: Lisette Scheer Date: Tue, 22 Apr 2025 20:22:38 +0000 Subject: [PATCH] Bug 20747: (QA follow-up) fix permissions on database update UPDATED TEST PLAN This patch adds new options to the LocalHoldsPriority system preference to allow for the following options: 'None' the equivalent to 'Don't' pre-patch 'GiveLibrary' the equivalent to 'Do' pre-patch 'GiveLibraryAndGroup' Allows for checking the library first, then hold groups 'GiveGroup' Allows to prioritize within a group without prioritizing any library first. The included patches will update the preference in existing installations to maintain current behavior. To Test: BEFORE APPLYING THE PATCH /Setup Groups and confirm current behavior/ 1. Set the " LocalHoldsPriority " system preference to "Give", "LocalHoldsPriorityPatronControl" to "home library" and "LocalHoldsPriorityItemControl" to "home library" 2. Create 2 Library Groups - Set them to be hold groups - I called mine group 1 & group 2 3. Add 2 libraries each to each group. - Group 1 - Centerville - Fairfield - Group 2 - Fairview - Franklin 4. Find a patron for each branch in the groups - Centerville - 23529000035676 (Henry) - Fairfield - Changed 23529000050113 - Fairview - Changed 23529001000463 (Edna) - Franklin - 23529000121682 5. Find a record with at least 2 items 6. If needed change the home and holding libraries so you have at least one item for each hold group - Centerville - 39999000000252 - Fairview - Changed 39999000000238 7. Place 2 record level holds for the record. - One for 23529000035676 for pickup at Centerville (Priority 1) - One for 23529001000463 for pickup at fairview (Priority 2) 8. Check in 39999000000238. The hold popup should be for the second hold, not the first. /apply patch and confirm behavior still works/ 9. Apply patch 10. Rebuild the database then restart_all (in sandboxes it's an action, in ktd " dbic && updatedatabase && restart_all ") 11. Confirm that " LocalHoldsPriority " is set to "Give Library" 12. Repeat steps 7-8, behavior should be the same. / check library then library group setting/ 13. Change " LocalHoldsPriority " to "Give library then library group" 14. Set the following record level holds for the record in the following order: - Pickup at Fairfield - 23529000050113 - Pickup at Franklin - 23529000121682 - Pickup at Centerville - 23529000035676 (Henry) - Pickup at Fairview - 23529001000463 (Edna) 15. Check in 39999000000252 - should try and fill to Centerville - 23529000035676 (Henry) 16. Check in 39999000000238 - should try and fill to Fairview - 23529001000463 (Edna) 17. Suspend the hold for 23529001000463 18. Check in 39999000000238 should try and fill to 23529000121682 / check library group setting / 19. Reset the holds to match step 14. 20. Change " LocalHoldsPriority " to "Give group" 21. Check in 39999000000252 - should try and fill to Fairfield 22. Check in 39999000000238 - should try and fill to Franklin /check no priority / 23. Change " LocalHoldsPriority " to "Don't give" 24. Reset the holds to match step 14. 25. Check in 39999000000238 - Should fill the Fairfield hold 26. Check in 39999000000252 - Should fill the Fairfield hold /Also check/ Item level holds behave as expected Different combinations of LocalHoldsPriorityItemControl and LocalHoldsPriorityPatronControl Sponsored by: Cape Libraries Automated Materials Sharing Sponsored by: Northeast Kansas Library System (NEKLS) --- .../mysql/db_revs/bug_20747-updatelocalholdspriority_syspref.pl | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755 installer/data/mysql/db_revs/bug_20747-updatelocalholdspriority_syspref.pl diff --git a/installer/data/mysql/db_revs/bug_20747-updatelocalholdspriority_syspref.pl b/installer/data/mysql/db_revs/bug_20747-updatelocalholdspriority_syspref.pl old mode 100644 new mode 100755 -- 2.39.5