From 23514eb12bbd25b191849a6cf8f1515ce0df8b79 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 19 Mar 2025 16:28:58 +0100 Subject: [PATCH] Bug 39325: Manual fixes Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens --- C4/Auth.pm | 2 +- C4/Biblio.pm | 2 +- C4/Circulation.pm | 6 ++-- C4/Form/MessagingPreferences.pm | 2 +- C4/Record.pm | 2 +- C4/Reports/Guided.pm | 4 +-- C4/Reserves.pm | 2 +- C4/SIP/SIPServer.pm | 12 +++---- Koha/Biblio.pm | 2 +- Koha/Edifact/Line.pm | 2 +- Koha/Edifact/Order.pm | 2 +- Koha/Filter/MARC/ViewPolicy.pm | 6 ++-- Koha/Item.pm | 2 +- Koha/Misc/Files.pm | 6 ++-- Koha/Patrons/Import.pm | 4 +-- Koha/Plugins/Base.pm | 2 +- Koha/Schema/Result/ClubHold.pm | 2 +- Koha/Schema/Result/Deleteditem.pm | 2 +- Koha/Schema/Result/Item.pm | 2 +- Koha/SearchEngine/Elasticsearch/Indexer.pm | 2 +- acqui/booksellers.pl | 2 +- acqui/check_budget_total.pl | 2 +- admin/aqbudgets.pl | 2 +- admin/check_budget_parent.pl | 2 +- authorities/authorities.pl | 2 +- catalogue/MARCdetail.pl | 2 +- cataloguing/addbooks.pl | 2 +- circ/returns.pl | 2 +- .../prog/en/includes/subtype_limits.inc | 4 +-- .../intranet-tmpl/prog/en/modules/about.tt | 10 +++--- .../authorities/searchresultlist-auth.tt | 30 ++++++++--------- .../modules/authorities/searchresultlist.tt | 30 ++++++++--------- .../value_builder/marc21_linking_section.tt | 28 ++++++++-------- .../value_builder/unimarc_field_210c.tt | 12 +++---- .../value_builder/unimarc_field_4XX.tt | 32 +++++++++---------- .../en/modules/labels/label-edit-batch.tt | 2 +- .../prog/en/modules/patroncards/edit-batch.tt | 2 +- .../en/modules/patroncards/image-manage.tt | 8 ++--- .../prog/en/modules/reserve/request.tt | 4 +-- .../intranet-tmpl/prog/js/ill-batch-modal.js | 16 +++++----- koha-tmpl/intranet-tmpl/prog/js/ill-batch.js | 6 ++-- .../bootstrap/en/includes/holds-table.inc | 2 +- .../bootstrap/en/modules/opac-advsearch.tt | 2 +- .../opac-authoritiessearchresultlist.tt | 16 +++++----- members/housebound.pl | 2 +- misc/cronjobs/advance_notices.pl | 2 +- misc/cronjobs/holds/holds_reminder.pl | 2 +- misc/cronjobs/membership_expiry.pl | 2 +- misc/cronjobs/overdue_notices.pl | 2 +- misc/cronjobs/update_patrons_category.pl | 4 +-- ...MARC_sync_date_created_with_marc_biblio.pl | 8 ++--- .../22_to_30/move_marc_to_authheader.pl | 2 +- misc/migration_tools/build_oai_sets.pl | 2 +- opac/opac-MARCdetail.pl | 2 +- opac/opac-suggestions.pl | 2 +- opac/opac-tags.pl | 2 +- suggestion/suggestion.pl | 2 +- svc/holds | 2 +- t/cypress/support/e2e.js | 2 +- t/db_dependent/Acquisition/GetBasketAsCSV.t | 4 +-- t/db_dependent/Biblio_holdsqueue.t | 2 +- t/db_dependent/Breeding.t | 6 ++-- t/db_dependent/Circulation.t | 2 +- t/db_dependent/Circulation/transferbook.t | 4 +-- t/db_dependent/HoldsQueue.t | 2 +- t/db_dependent/LDAP/test_ldap_add.pl | 2 +- t/db_dependent/Languages.t | 2 +- t/db_dependent/Letters.t | 2 +- t/db_dependent/OAI/Sets.t | 2 +- t/db_dependent/Search.t | 4 +-- t/db_dependent/Serials.t | 2 +- .../Utils/Datatables_Virtualshelves.t | 4 +-- t/db_dependent/api/v1/stockrotationstage.t | 4 +-- 73 files changed, 183 insertions(+), 183 deletions(-) diff --git a/C4/Auth.pm b/C4/Auth.pm index 3f8b7fce6e3..dbececfcbca 100644 --- a/C4/Auth.pm +++ b/C4/Auth.pm @@ -1032,7 +1032,7 @@ sub checkauth { if ($logout) { # voluntary logout the user - # check FIXME CODESPELL (wether ==> weather, whether) the user was using their shibboleth session or a local one + # check whether the user was using their shibboleth session or a local one my $shibSuccess = C4::Context->userenv ? C4::Context->userenv->{'shibboleth'} : undef; if ($session) { $session->delete(); diff --git a/C4/Biblio.pm b/C4/Biblio.pm index a04aa28fd27..41923f1dfd2 100644 --- a/C4/Biblio.pm +++ b/C4/Biblio.pm @@ -2303,7 +2303,7 @@ sub TransformHtmlToMarc { $newfield = 0; my $j = $i + 2; - if ( $tag < 10 ) { # no code for FIXME CODESPELL (theses ==> these, thesis) fields + if ( $tag < 10 ) { # no code for this field # in MARC editor, 000 contains the leader. next if $tag == $biblionumbertagfield; my $fval = $cgi->param( $params[ $j + 1 ] ); diff --git a/C4/Circulation.pm b/C4/Circulation.pm index 3b824a3730d..abea785d9a9 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -1574,8 +1574,8 @@ AddIssue does the following things : - fill recall if recall to this patron - cancel recall or not - revert recall's waiting status or not - * FIXME CODESPELL (TRANSFERT ==> TRANSFER, TRANSFERRED) PENDING ? - - complete the FIXME CODESPELL (transfert ==> transfer, transferred) + * TRANSFER PENDING ? + - complete the transfer * ISSUE THE BOOK =back @@ -1704,7 +1704,7 @@ sub AddIssue { C4::Reserves::MoveReserve( $item_object->itemnumber, $patron->borrowernumber, $cancelreserve ); - # Starting process for transfer job (checking FIXME CODESPELL (transfert ==> transfer, transferred) and validate it if we have one) + # Starting process for transfer job (checking transfer and validate it if we have one) if ( my $transfer = $item_object->get_transfer ) { # updating line of branchtranfert to finish it, and changing the to branch value, implement a comment for visibility of this case (maybe for stats ....) diff --git a/C4/Form/MessagingPreferences.pm b/C4/Form/MessagingPreferences.pm index 6c1aecc578a..88c8e08fe11 100644 --- a/C4/Form/MessagingPreferences.pm +++ b/C4/Form/MessagingPreferences.pm @@ -156,7 +156,7 @@ PREF: foreach my $option (@$messaging_options) { =item Handle when form input is invalid -=item Generalize into a system of form handler FIXME CODESPELL (clases ==> classes, clashes, cases) +=item Generalize into a system of form handler classes =back diff --git a/C4/Record.pm b/C4/Record.pm index 33931358702..30ce148868a 100644 --- a/C4/Record.pm +++ b/C4/Record.pm @@ -264,7 +264,7 @@ sub marc2dcxml { my ( $marcxml, $record, $output ); # set the default path for intranet xslts - # FIXME CODESPELL (differents ==> different, difference) xslts to process (OAIDC, SRWDC and RDFDC) + # different xslts to process (OAIDC, SRWDC and RDFDC) my $xsl = C4::Context->config('intrahtdocs') . '/prog/en/xslt/' diff --git a/C4/Reports/Guided.pm b/C4/Reports/Guided.pm index 50f9b37379d..94e271cef7b 100644 --- a/C4/Reports/Guided.pm +++ b/C4/Reports/Guided.pm @@ -307,8 +307,8 @@ sub _build_query { my @definitions = split( ',', $definition ); my $deftext; foreach my $def (@definitions) { - my $define = get_from_dictionary( '', $def ); - $deftext .= " " . $defin->[0]->{'saved_sql'}; + my $report = get_from_dictionary( '', $def ); + $deftext .= " " . $report->[0]->{'saved_sql'}; } if ( $query =~ /WHERE/i ) { $query .= $deftext; diff --git a/C4/Reserves.pm b/C4/Reserves.pm index a6c0a10c6c9..3dc72f02264 100644 --- a/C4/Reserves.pm +++ b/C4/Reserves.pm @@ -59,7 +59,7 @@ C4::Reserves - Koha functions for dealing with reservation. =head1 DESCRIPTION -This modules provides FIXME CODESPELL (somes ==> some, sums) functions to deal with reservations. +This modules provides some functions to deal with reservations. Reserves are stored in reserves table. The following columns contains important values : diff --git a/C4/SIP/SIPServer.pm b/C4/SIP/SIPServer.pm index bb9b4bbd5e1..d897a55a375 100644 --- a/C4/SIP/SIPServer.pm +++ b/C4/SIP/SIPServer.pm @@ -55,13 +55,13 @@ my %transports = ( # Read configuration # my $config = C4::SIP::Sip::Configuration->new( $ARGV[0] ); -my @FIXME CODESPELL (parms ==> params, prams); +my @params; # # Ports to bind # foreach my $svc ( keys %{ $config->{listeners} } ) { - push @FIXME CODESPELL (parms ==> params, prams), "port=" . $svc; + push @params, "port=" . $svc; } # @@ -81,17 +81,17 @@ foreach my $svc ( keys %{ $config->{listeners} } ) { # if ( defined( $config->{'server-params'} ) ) { while ( my ( $key, $val ) = each %{ $config->{'server-params'} } ) { - push @FIXME CODESPELL (parms ==> params, prams), $key . '=' . $val; + push @params, $key . '=' . $val; } } # Add user and group to prevent warn from Net::Server. -push @FIXME CODESPELL (parms ==> params, prams), 'user=' . $>; -push @FIXME CODESPELL (parms ==> params, prams), 'group=' . $>; +push @params, 'user=' . $>; +push @params, 'group=' . $>; # # This is the main event. -__PACKAGE__->run(@FIXME CODESPELL (parms ==> params, prams)); +__PACKAGE__->run(@params); # # Server diff --git a/Koha/Biblio.pm b/Koha/Biblio.pm index 944a0c95c28..487500de110 100644 --- a/Koha/Biblio.pm +++ b/Koha/Biblio.pm @@ -520,7 +520,7 @@ sub pickup_locations { my $bool = $biblio->hidden_in_opac({ [ rules => $rules ] }) -Returns true if the biblio matches the FIXME CODESPELL (hidding ==> hiding, hidden) criteria defined in $rules. +Returns true if the biblio matches the hiding criteria defined in $rules. Returns false otherwise. It involves the I and I system preferences. diff --git a/Koha/Edifact/Line.pm b/Koha/Edifact/Line.pm index cc34ad6eae2..be83bd2c77b 100644 --- a/Koha/Edifact/Line.pm +++ b/Koha/Edifact/Line.pm @@ -778,7 +778,7 @@ sub pri_price { return; } -# unit price that will be FIXME CODESPELL (chaged ==> changed, charged) excl tax +# unit price that will be charged excl tax sub price_net { my $self = shift; diff --git a/Koha/Edifact/Order.pm b/Koha/Edifact/Order.pm index 8df91a6132d..0bf67829cae 100644 --- a/Koha/Edifact/Order.pm +++ b/Koha/Edifact/Order.pm @@ -776,7 +776,7 @@ Make handling of GIR segments more customizable pass the string 'new'. In practice we encode 1 message per transmission so there is only one message referenced. were we to encode multiple messages a new reference would be - FIXME CODESPELL (neaded ==> needed, kneaded, headed) for each + needed for each =head2 message_header diff --git a/Koha/Filter/MARC/ViewPolicy.pm b/Koha/Filter/MARC/ViewPolicy.pm index f53a8e2c2d7..e78584d8957 100644 --- a/Koha/Filter/MARC/ViewPolicy.pm +++ b/Koha/Filter/MARC/ViewPolicy.pm @@ -232,9 +232,9 @@ nothing is passed. Valid values include 'opac' or 'intranet'. =cut sub should_hide_marc { - my ( $self, $FIXME CODESPELL (parms ==> params, prams) ) = @_; - my $frameworkcode = $parms->{frameworkcode} // q{}; - my $interface = $parms->{interface} // 'opac'; + my ( $self, $params ) = @_; + my $frameworkcode = $params->{frameworkcode} // q{}; + my $interface = $params->{interface} // 'opac'; my $hide = _should_hide_on_interface(); my %shouldhidemarc; diff --git a/Koha/Item.pm b/Koha/Item.pm index b576a1a92f2..bfcecbc8f26 100644 --- a/Koha/Item.pm +++ b/Koha/Item.pm @@ -935,7 +935,7 @@ sub can_article_request { my $bool = $item->hidden_in_opac({ [ rules => $rules ] }) -Returns true if item fields match the FIXME CODESPELL (hidding ==> hiding, hidden) criteria defined in $rules. +Returns true if item fields match the hiding criteria defined in $rules. Returns false otherwise. Takes HASHref that can have the following parameters: diff --git a/Koha/Misc/Files.pm b/Koha/Misc/Files.pm index 2bbd0702af9..98bb95885af 100644 --- a/Koha/Misc/Files.pm +++ b/Koha/Misc/Files.pm @@ -52,7 +52,7 @@ from this table. However, this method does accept an arbitrary string as 'tabletag', and an arbitrary integer as 'recordid'. Particular Koha::Misc::Files object can have one or more file records -(FIXME CODESPELL (actuall ==> actually, actual) file contents + various file metadata) associated with it. +(actual file contents + various file metadata) associated with it. In case of an error (wrong parameter format) it returns undef. @@ -150,7 +150,7 @@ my $file = $mf->GetFile( id => $file_id ); For an individual, specific file ID this method returns a hashref containing all metadata (file_id, table_tag, record_id, file_name, file_type, file_description, file_content, date_uploaded), plus -an FIXME CODESPELL (actuall ==> actually, actual) contents of a file (in 'file_content'). In typical usage +an actually contents of a file (in 'file_content'). In typical usage scenarios, for a given $mf object, specific file IDs have to be obtained first by GetFilesInfo() call. @@ -218,7 +218,7 @@ sub DelAllFiles { $mf->MergeFileRecIds(@ids_to_be_merged); -This method re-associates all FIXME CODESPELL (individuall ==> individually, individual) file records associated with +This method re-associates all individual file records associated with some "parent" records IDs (provided in @ids_to_be_merged) with the given single $mf object (which would be treated as a "parent" destination). diff --git a/Koha/Patrons/Import.pm b/Koha/Patrons/Import.pm index b2baa90d626..23b6f578031 100644 --- a/Koha/Patrons/Import.pm +++ b/Koha/Patrons/Import.pm @@ -768,9 +768,9 @@ sub format_dates { my ( $self, $params ) = @_; foreach my $date_type (qw(dateofbirth dateenrolled dateexpiry date_renewed)) { - my $template = $params->{borrower}->{$date_type} or next(); + my $tmp_date = $params->{borrower}->{$date_type} or next(); my $formatted_date = - eval { output_pref( { dt => dt_from_string($template), dateonly => 1, dateformat => 'iso' } ); }; + eval { output_pref( { dt => dt_from_string($tmp_date), dateonly => 1, dateformat => 'iso' } ); }; if ($formatted_date) { $params->{borrower}->{$date_type} = $formatted_date; diff --git a/Koha/Plugins/Base.pm b/Koha/Plugins/Base.pm index 3fed733e643..e0e8f9a49f9 100644 --- a/Koha/Plugins/Base.pm +++ b/Koha/Plugins/Base.pm @@ -359,7 +359,7 @@ sub _version_compare { =head2 is_enabled -Method that returns FIXME CODESPELL (wether ==> weather, whether) the plugin is enabled or not +Method that returns whether the plugin is enabled or not $plugin->enable diff --git a/Koha/Schema/Result/ClubHold.pm b/Koha/Schema/Result/ClubHold.pm index 02fd5109dbe..393a1686195 100644 --- a/Koha/Schema/Result/ClubHold.pm +++ b/Koha/Schema/Result/ClubHold.pm @@ -51,7 +51,7 @@ id for the bibliographic record the hold has been placed against is_foreign_key: 1 is_nullable: 1 -If item-level, the id for the item the hold has been placed FIXME CODESPELL (agains ==> against, again) +If item-level, the id for the item the hold has been placed against =head2 date_created diff --git a/Koha/Schema/Result/Deleteditem.pm b/Koha/Schema/Result/Deleteditem.pm index c49a62d99ac..a8114ea1fb9 100644 --- a/Koha/Schema/Result/Deleteditem.pm +++ b/Koha/Schema/Result/Deleteditem.pm @@ -383,7 +383,7 @@ inventory number (MARC21 952$i) is_nullable: 1 size: 32 -'new' value, you can put whatever free-text information. This field is FIXME CODESPELL (intented ==> intended, indented) to be managed by the automatic_item_modification_by_age cronjob. +'new' value, you can put whatever free-text information. This field is intended to be managed by the automatic_item_modification_by_age cronjob. =head2 exclude_from_local_holds_priority diff --git a/Koha/Schema/Result/Item.pm b/Koha/Schema/Result/Item.pm index aaf4101f854..314babd5b9e 100644 --- a/Koha/Schema/Result/Item.pm +++ b/Koha/Schema/Result/Item.pm @@ -387,7 +387,7 @@ inventory number (MARC21 952$i) is_nullable: 1 size: 32 -'new' value, you can put whatever free-text information. This field is FIXME CODESPELL (intented ==> intended, indented) to be managed by the automatic_item_modification_by_age cronjob. +'new' value, you can put whatever free-text information. This field is intended to be managed by the automatic_item_modification_by_age cronjob. =head2 exclude_from_local_holds_priority diff --git a/Koha/SearchEngine/Elasticsearch/Indexer.pm b/Koha/SearchEngine/Elasticsearch/Indexer.pm index f5c42deca1b..3a69e5814e3 100644 --- a/Koha/SearchEngine/Elasticsearch/Indexer.pm +++ b/Koha/SearchEngine/Elasticsearch/Indexer.pm @@ -255,7 +255,7 @@ sub index_status { Generate Elasticsearch mappings from mappings stored in database and perform a request to update Elasticsearch index mappings. Will throw an error and set index status to C if update -fails. +failed. =cut diff --git a/acqui/booksellers.pl b/acqui/booksellers.pl index 999489253b5..f7cdc17df1c 100755 --- a/acqui/booksellers.pl +++ b/acqui/booksellers.pl @@ -28,7 +28,7 @@ booksellers.pl =head1 DESCRIPTION this script displays the list of suppliers & baskets like C<$supplier> given on input arg. -thus, this page brings FIXME CODESPELL (differents ==> different, difference) features like to display supplier's details, +thus, this page brings different features like to display supplier's details, to add an order for a specific supplier or to just add a new supplier. =head1 CGI PARAMETERS diff --git a/acqui/check_budget_total.pl b/acqui/check_budget_total.pl index 20aabbe4459..31aa81b5cb9 100755 --- a/acqui/check_budget_total.pl +++ b/acqui/check_budget_total.pl @@ -26,7 +26,7 @@ use C4::Budgets qw( GetBudget ); =head1 DESCRIPTION -fetches the budget amount FIXME CODESPELL (fron ==> from, front) the DB +fetches the budget amount from the DB =cut diff --git a/admin/aqbudgets.pl b/admin/aqbudgets.pl index 83023afa466..c803744462e 100755 --- a/admin/aqbudgets.pl +++ b/admin/aqbudgets.pl @@ -254,7 +254,7 @@ if ( $op eq 'list' ) { my $period_total = 0; my ( $period_alloc_total, $spent_total, $ordered_total, $available_total ) = ( 0, 0, 0, 0 ); - #This Looks WEIRD to me : should budgets be filtered in such a way ppl who FIXME CODESPELL (donot ==> do not, donut) own it would not see the amount spent on the budget by others ? + #This Looks WEIRD to me : should budgets be filtered in such a way ppl who do not own it would not see the amount spent on the budget by others ? my @budgets_to_display; foreach my $budget (@budgets) { diff --git a/admin/check_budget_parent.pl b/admin/check_budget_parent.pl index 4ab893673a9..1ecc463040d 100755 --- a/admin/check_budget_parent.pl +++ b/admin/check_budget_parent.pl @@ -26,7 +26,7 @@ use C4::Budgets qw( CheckBudgetParent GetBudget ); =head1 DESCRIPTION -fetches the budget amount FIXME CODESPELL (fron ==> from, front) the DB, +fetches the budget amount from the DB, called by aqbudgets.pl and neworderempty.pl =cut diff --git a/authorities/authorities.pl b/authorities/authorities.pl index 120c481e615..6080478fdec 100755 --- a/authorities/authorities.pl +++ b/authorities/authorities.pl @@ -438,7 +438,7 @@ sub build_tabs { fixedfield => ( $tag < 10 ) ? (1) : (0), random => CreateKey, ); - if ( $tag >= 10 ) { # no indicator for FIXME CODESPELL (theses ==> these, thesis) tag + if ( $tag >= 10 ) { # no indicator for this tag $tag_data{indicator1} = format_indicator( $field->indicator(1) ), $tag_data{indicator2} = format_indicator( $field->indicator(2) ),; } diff --git a/catalogue/MARCdetail.pl b/catalogue/MARCdetail.pl index 2f08086341f..b90822c059c 100755 --- a/catalogue/MARCdetail.pl +++ b/catalogue/MARCdetail.pl @@ -251,7 +251,7 @@ for ( my $tabloop = 0 ; $tabloop <= 10 ; $tabloop++ ) { # now, build item tab ! # the main difference is that datas are in lines and not in columns : thus, we build the first, then the values... # loop through each tag -# warning : we may have FIXME CODESPELL (differents ==> different, difference) number of columns in each row. Thus, we first build a hash, complete it if necessary +# warning : we may have different number of columns in each row. Thus, we first build a hash, complete it if necessary # then construct template. my @fields = $record->fields(); my %witness; #---- stores the list of subfields used at least once, with the "meaning" of the code diff --git a/cataloguing/addbooks.pl b/cataloguing/addbooks.pl index b252645a095..7b2833cc8d0 100755 --- a/cataloguing/addbooks.pl +++ b/cataloguing/addbooks.pl @@ -83,7 +83,7 @@ if ($query) { } # format output - # SimpleSearch() give the results per page we want, so 0 FIXME CODESPELL (offet ==> offset, offer) here + # SimpleSearch() give the results per page we want, so 0 offset here my $total = @{$marcresults}; my @newresults = searchResults( { 'interface' => 'intranet' }, $query, $total, $results_per_page, 0, 0, $marcresults ); diff --git a/circ/returns.pl b/circ/returns.pl index 4b46ab29744..9d221305bec 100755 --- a/circ/returns.pl +++ b/circ/returns.pl @@ -534,7 +534,7 @@ if ( $messages->{'Wrongbranch'} ) { ); } -# case of wrong FIXME CODESPELL (transfert ==> transfer, transferred), if the document wasn't transferred to the right library (according to branchtransfer (tobranch) BDD) +# case of wrong transfer, if the document wasn't transferred to the right library (according to branchtransfer (tobranch) BDD) if ( $messages->{'WrongTransfer'} and not $messages->{'WasTransfered'} ) { diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/subtype_limits.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/subtype_limits.inc index 5990689c3c3..c6c80de0f8b 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/subtype_limits.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/subtype_limits.inc @@ -197,9 +197,9 @@ [% END %] [% IF (limits.ctype.0 == 'm' ) %] - + [% ELSE %] - + [% END %] [% IF (limits.ctype.0 == 'n' ) %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt index 3b3e03fdbac..2ff35d710a4 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt @@ -272,9 +272,9 @@ [% WRAPPER tab_panel tabname= "perl" bt_active = 1 %] - [% FOREACH table IN tablee %] + [% FOREACH line IN table %] - [% FOREACH ro IN table.row %] + [% FOREACH ro IN line.row %] [% IF ( ro.require ) %] [% SET th_font_weight = "bold" %] [% ELSE %] @@ -313,7 +313,7 @@ [% END %] [% END # /FOREACH ro %] - [% END # /FOREACH table %] + [% END # /FOREACH line %]
Perl modules
[% END # tab=perl %] [% END %] @@ -1246,9 +1246,9 @@ Description - [% FOREACH table IN tablee2 %] + [% FOREACH line IN table2 %] - [% FOREACH ro IN table.row2 %] + [% FOREACH ro IN line.row2 %] [% ro.date | html %] [% ro.desc | html %] [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist-auth.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist-auth.tt index 99596286a3d..52ce4fdc065 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist-auth.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist-auth.tt @@ -93,19 +93,19 @@ Get it! Other action - [% FOREACH result IN resultt %] + [% FOREACH line IN result %] - [% IF result.html %] - [% result.html | $raw %] + [% IF line.html %] + [% line.html | $raw %] [% ELSE %] - [% PROCESS authresulttt summary=resultt.summary authid=resultt.authid auth_preview=1 %] + [% PROCESS authresult summary=line.summary authid=line.authid auth_preview=1 %] [% END %] - [% result.summary.label | html %] + [% line.summary.label | html %] - [% IF result.used > 0 %] - [% resultt.used | html %] times + [% IF line.used > 0 %] + [% line.used | html %] times [% ELSE %] 0 times [% END %] @@ -113,23 +113,23 @@ [% IF Koha.Preference('ShowHeadingUse') %]
    -
  • [% IF result.main %][% ELSE %][% END %] Main/Added Entry
  • -
  • [% IF result.subject %][% ELSE %][% END %] Subject
  • -
  • [% IF result.series %][% ELSE %][% END %] Series Title
  • +
  • [% IF line.main %][% ELSE %][% END %] Main/Added Entry
  • +
  • [% IF line.subject %][% ELSE %][% END %] Subject
  • +
  • [% IF line.series %][% ELSE %][% END %] Series Title
[% END %] - [% IF resulttt.summary && resulttt.summary.authorized && resulttt.summary.authorized.size > 1 %] - [% FOREACH authorized IN result.summary.authorized %] - [% loop.count | html %] + [% IF line.summary && line.summary.authorized && line.summary.authorized.size > 1 %] + [% FOREACH authorized IN line.summary.authorized %] + [% loop.count | html %] [% END %] [% ELSE %] - Choose + Choose [% END %] Edit authority Edit authority [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt index 6793c0ef30c..fd03ce9cf37 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt @@ -73,20 +73,20 @@   [% END %] - [% FOREACH result IN resultt %] + [% FOREACH line IN result %] [% IF result.html %] [% result.html | $raw %] [% ELSE %] - [% PROCESS authresulttt summary=resultt.summary authid=resultt.authid %] + [% PROCESS authresult summary=line.summary authid=line.authid %] [% END %] - [% result.authtype | html %] - [% UNLESS ( result.isEDITORS ) %] + [% line.authtype | html %] + [% UNLESS ( line.isEDITORS ) %] - [% IF result.used > 0 %] - [% resultt.used | html %] record(s) + [% IF line.used > 0 %] + [% line.used | html %] record(s) [% ELSE %] 0 records [% END %] @@ -95,29 +95,29 @@ [% IF Koha.Preference('ShowHeadingUse') %]
    -
  • [% IF result.main %][% ELSE %][% END %] Main/Added Entry
  • -
  • [% IF result.subject %][% ELSE %][% END %] Subject
  • -
  • [% IF result.series %][% ELSE %][% END %] Series Title
  • +
  • [% IF line.main %][% ELSE %][% END %] Main/Added Entry
  • +
  • [% IF line.subject %][% ELSE %][% END %] Subject
  • +
  • [% IF line.series %][% ELSE %][% END %] Series Title
[% END %] [% IF ( CAN_user_editauthorities ) %]
- Actions -
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_linking_section.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_linking_section.tt index 647f0cbe5ab..61bc7a1265b 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_linking_section.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_linking_section.tt @@ -84,33 +84,33 @@ Concise description   - [% FOREACH result IN resultt %] - [% IF ( result.title ) %] + [% FOREACH line IN result %] + [% IF ( line.title ) %] [% SET td_class = '' %] - [% IF ( result.even ) %] + [% IF ( line.even ) %] [% td_class = 'hilighted' %] [% END %] - [% IF ( result.MARC_ON ) %] - [% resultt.title | html %] + [% IF ( line.MARC_ON ) %] + [% line.title | html %] [% ELSE %] - [% resultt.title | html %] + [% line.title | html %] [% END %]

[% result.author | html %] - [% IF ( resultt.publishercode ) %]- [% resultt.publishercode | html %][% END %] - [% IF ( resultt.place ) %]; [% resultt.place | html %][% END %] - [% IF ( resultt.pages ) %]- [% resultt.pages | html %][% END %] - [% IF ( resultt.notes ) %]: [% resultt.notes | html %][% END %] - [% IF ( resultt.size ) %]; [% resultt.size | html %][% END %] + >[% line.author | html %] + [% IF ( line.publishercode ) %]- [% line.publishercode | html %][% END %] + [% IF ( line.place ) %]; [% line.place | html %][% END %] + [% IF ( line.pages ) %]- [% line.pages | html %][% END %] + [% IF ( line.notes ) %]: [% line.notes | html %][% END %] + [% IF ( line.size ) %]; [% line.size | html %][% END %]

- [% IF ( result.biblionumber ) %] + [% IF ( line.biblionumber ) %] Choose [% ELSE %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_210c.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_210c.tt index cf9629c080b..a0f925464b2 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_210c.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_210c.tt @@ -68,15 +68,15 @@ Used Get it! - [% FOREACH result IN resultt %] + [% FOREACH line IN result %] - [% PROCESS authresulttt summary=resultt.summary authid=resultt.authid %] - [% result.summary.label | html %] - [% result.used | html %] times + [% PROCESS authresult summary=line.summary authid=line.authid %] + [% line.summary.label | html %] + [% line.used | html %] times - [% IF ( result.to_report ) %] + [% IF ( line.to_report ) %] - + [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt index a759bce1e7f..08ddcdfa259 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt @@ -89,36 +89,36 @@ Location   - [% FOREACH result IN resultt %] - [% IF ( result.title ) %] + [% FOREACH line IN result %] + [% IF ( line.title ) %] [% SET td_class = '' %] - [% IF ( result.even ) %] + [% IF ( line.even ) %] [% td_class = 'hilighted' %] [% END %] - [% IF ( result.MARC_ON ) %] - [% resultt.title | html %] + [% IF ( line.MARC_ON ) %] + [% line.title | html %] [% ELSE %] - [% resultt.fulltitle | html %] + [% line.fulltitle | html %] [% END %]

[% result.author | html %] - [% IF ( resultt.publishercode ) %]- [% resultt.publishercode | html %][% END %] - [% IF ( resultt.place ) %]; [% resultt.place | html %][% END %] - [% IF ( resultt.pages ) %]- [% resultt.pages | html %][% END %] - [% IF ( resultt.notes ) %]: [% resultt.notes | html %][% END %] - [% IF ( resultt.item('size') ) %]; [% resultt.item('size') | html %][% END %] + >[% line.author | html %] + [% IF ( line.publishercode ) %]- [% line.publishercode | html %][% END %] + [% IF ( line.place ) %]; [% line.place | html %][% END %] + [% IF ( line.pages ) %]- [% line.pages | html %][% END %] + [% IF ( line.notes ) %]: [% line.notes | html %][% END %] + [% IF ( line.item('size') ) %]; [% line.item('size') | html %][% END %]

- [% result.totitem | html %] - [% result.CN | html %] + [% line.totitem | html %] + [% line.CN | html %] - [% IF ( result.biblionumber ) %] + [% IF ( line.biblionumber ) %] Choose [% ELSE %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt index a8351fa2c12..742d520a0b6 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt @@ -320,7 +320,7 @@ } else if (mode == 'batch') { return GB_showCenter(_("Export labels"), "/cgi-bin/koha/labels/label-print.pl?batch_id=[% batch_id | html %]", 400, 800); } else { - // some pass-thru error trapping just in case... + // some pass-through error trapping just in case... } } diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt index cf03cd719c8..1ee578a3b22 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt @@ -269,7 +269,7 @@ } else if (mode == 'batch') { return GB_showCenter(_("Export patron cards"), "/cgi-bin/koha/patroncards/print.pl?batch_id=[% batch_id | html %]", 400, 800); } else { - // some pass-thru error trapping just in case... + // some pass-through error trapping just in case... } }; function selected_layout() { diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt index 8160aaf7737..3206ee48a84 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt @@ -82,11 +82,11 @@
Select one or more images to delete.
- [% FOREACH TABLE IN TABLEE %] + [% FOREACH line IN TABLE %] - [% IF ( TABLE.header_fields ) %] + [% IF ( line.header_fields ) %] - [% FOREACH header_field IN TABLE.header_fields %] + [% FOREACH header_field IN line.header_fields %] [% SWITCH header_field.field_label -%] [% CASE "ID" %] @@ -101,7 +101,7 @@ [% ELSE %] - [% FOREACH text_field IN TABLE.text_fields %] + [% FOREACH text_field IN line.text_fields %] [% IF ( text_field.select_field ) %] - [% FOREACH result IN resultt %] + [% FOREACH line IN result %] - - [% UNLESS ( result.isEDITORS ) %] + + [% UNLESS ( line.isEDITORS ) %]
Image ID
0) { diff --git a/koha-tmpl/intranet-tmpl/prog/js/ill-batch.js b/koha-tmpl/intranet-tmpl/prog/js/ill-batch.js index 7abdfc1728e..79d434ee374 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/ill-batch.js +++ b/koha-tmpl/intranet-tmpl/prog/js/ill-batch.js @@ -3,10 +3,10 @@ // If we're working with an existing batch, set the ID so the // modal can access it window.openBatchModal = function (id, backend) { - var idle = document.getElementById("ill-batch-details"); - idle.dataset.backend = backend; + var elId = document.getElementById("ill-batch-details"); + elId.dataset.backend = backend; if (id) { - idle.dataset.batchId = id; + elId.dataset.batchId = id; } $("#ill-batch-modal").modal("show"); }; diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc index 576e2dcc514..201477bb0f9 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc +++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc @@ -44,7 +44,7 @@ [% IF ( HOLD.is_at_destination ) %] [% tr_class = 'reserved' %] [% ELSIF HOLD.is_in_transit %] - [% tr_class = 'transfered' %] + [% tr_class = 'transferred' %] [% END %]
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt index 48aeb54d713..c91020549e3 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt @@ -454,7 +454,7 @@ - + diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt index 4ac5f9e52de..65ea6ae7cee 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt @@ -76,20 +76,20 @@
- [% IF result.html %] - [% result.html | $raw %] + [% IF line.html %] + [% line.html | $raw %] [% ELSE %] - [% PROCESS authresulttt summary=resultt.summary authid=resultt.authid %] + [% PROCESS authresult summary=line.summary authid=line.authid %] [% END %] Details [% resultt.authtype | html %]Details [% line.authtype | html %] - [% IF result.used > 0 %] - [% resulttt.used | html %] [% tn('record', 'records', resulttt.used ) | html %] + [% IF line.used > 0 %] + [% line.used | html %] [% tn('record', 'records', line.used ) | html %] [% ELSE %] 0 records [% END %] diff --git a/members/housebound.pl b/members/housebound.pl index ee6a096165e..1e4b31903fa 100755 --- a/members/housebound.pl +++ b/members/housebound.pl @@ -122,7 +122,7 @@ if ( $op eq 'cud-updateconfirm' and $houseboundprofile ) { $houseboundvisit = $visit; } elsif ( $op eq 'cud-visit_delete' and $visit ) { - # We want ot delete a specific visit. + # We want to delete a specific visit. my $success = eval { return $visit->delete }; push @messages, { type => 'error', code => 'error_on_visit_delete' } if ( $@ or !$success ); diff --git a/misc/cronjobs/advance_notices.pl b/misc/cronjobs/advance_notices.pl index 007e017937d..82fd3101b19 100755 --- a/misc/cronjobs/advance_notices.pl +++ b/misc/cronjobs/advance_notices.pl @@ -141,7 +141,7 @@ program. They may be redirected to a file if desired. =head2 Templates Templates can contain variables enclosed in double angle brackets like -EEFIXME CODESPELL (thisE ==> these, this)E. Those variables will be replaced with values +<>. Those variables will be replaced with values specific to the overdue items or relevant patron. Available variables are: diff --git a/misc/cronjobs/holds/holds_reminder.pl b/misc/cronjobs/holds/holds_reminder.pl index 12cbab0fbfc..92d2dfc8bda 100755 --- a/misc/cronjobs/holds/holds_reminder.pl +++ b/misc/cronjobs/holds/holds_reminder.pl @@ -202,7 +202,7 @@ unless ( defined $days ) { $days = 0; } -# Unless one ore more branchcodes are passed we use all the branches +# Unless one or more branchcodes are passed we use all the branches if ( scalar @branchcodes > 0 ) { my $branchcodes_word = scalar @branchcodes > 1 ? 'branches' : 'branch'; $verbose and warn "$branchcodes_word @branchcodes passed on parameter\n"; diff --git a/misc/cronjobs/membership_expiry.pl b/misc/cronjobs/membership_expiry.pl index ff34becb5fb..228c15d71ca 100755 --- a/misc/cronjobs/membership_expiry.pl +++ b/misc/cronjobs/membership_expiry.pl @@ -142,7 +142,7 @@ not the borrower has an email address. This can be useful for libraries that prefer to deal with print notices. Notices can contain variables enclosed in double angle brackets like -EEFIXME CODESPELL (thisE ==> these, this)E. Those variables will be replaced with values +<>. Those variables will be replaced with values specific to the soon expiring members. Available variables are: diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl index 7f57d6faf3a..41ece5923d1 100755 --- a/misc/cronjobs/overdue_notices.pl +++ b/misc/cronjobs/overdue_notices.pl @@ -227,7 +227,7 @@ program. They may be redirected to a file if desired. =head2 Templates Templates can contain variables enclosed in double angle brackets like -EEFIXME CODESPELL (thisE ==> these, this)E. Those variables will be replaced with values +<>. Those variables will be replaced with values specific to the overdue items or relevant patron. Available variables are: diff --git a/misc/cronjobs/update_patrons_category.pl b/misc/cronjobs/update_patrons_category.pl index 14372a28976..c4c8f7e2a74 100755 --- a/misc/cronjobs/update_patrons_category.pl +++ b/misc/cronjobs/update_patrons_category.pl @@ -109,11 +109,11 @@ Supply a number and only account with fines under this number will be updated. =item B<--regbefore=date | -rb=date> -Enter a date in ISO format YYYY-MM-DD and only patrons registered before this date FIXME CODESPELL (wil ==> will, well) be updated. +Enter a date in ISO format YYYY-MM-DD and only patrons registered before this date will be updated. =item B<--regafter=date | -ra=date> -Enter a date in ISO format YYYY-MM-DD and only patrons registered after this date FIXME CODESPELL (wil ==> will, well) be updated. +Enter a date in ISO format YYYY-MM-DD and only patrons registered after this date will be updated. =item B<--field column=value | -d column=value> diff --git a/misc/maintenance/UNIMARC_sync_date_created_with_marc_biblio.pl b/misc/maintenance/UNIMARC_sync_date_created_with_marc_biblio.pl index b7f19e3ed9c..428e3be46fa 100755 --- a/misc/maintenance/UNIMARC_sync_date_created_with_marc_biblio.pl +++ b/misc/maintenance/UNIMARC_sync_date_created_with_marc_biblio.pl @@ -48,9 +48,9 @@ $verbose and print "================================\n"; $date_created_marc = '099c' unless $date_created_marc; my ( $c_field, $c_subfield ) = _read_marc_code($date_created_marc); die "date-created-marc '$date_created_marc' is not correct." unless $c_field; -die "date-created-marc field is FIXME CODESPELL (greated ==> greater, grated, graded) that 009, it should have a subfield." +die "date-created-marc field is greater than 009, it should have a subfield." if ( $c_field > 9 && !defined $c_subfield ); -die "date-created-marc field is lower that 010, it should not have a subfield." +die "date-created-marc field is lower than 010, it should not have a subfield." if ( $c_field < 10 && defined $c_subfield ); if ($verbose) { print "Date created on $c_field"; @@ -62,9 +62,9 @@ if ($verbose) { $date_modified_marc = '099d' unless $date_modified_marc; my ( $m_field, $m_subfield ) = _read_marc_code($date_modified_marc); die "date-modified-marc '$date_modified_marc' is not correct." unless $m_field; -die "date-modified-marc field is FIXME CODESPELL (greated ==> greater, grated, graded) that 009, it should have a subfield." +die "date-modified-marc field is greater than 009, it should have a subfield." if ( $m_field > 9 && !defined $m_subfield ); -die "date-modified-marc field is lower that 010, it should not have a subfield." +die "date-modified-marc field is lower than 010, it should not have a subfield." if ( $m_field < 10 && defined $m_subfield ); die "When date-created-marc and date-modified-marc are on same field, they should have distinct subfields" if ( $c_field eq $m_field ) diff --git a/misc/migration_tools/22_to_30/move_marc_to_authheader.pl b/misc/migration_tools/22_to_30/move_marc_to_authheader.pl index 2c0b7a41a61..6131f1bd7e6 100755 --- a/misc/migration_tools/22_to_30/move_marc_to_authheader.pl +++ b/misc/migration_tools/22_to_30/move_marc_to_authheader.pl @@ -51,7 +51,7 @@ while ( my ( $authid, $authtypecode ) = $sth->fetchrow ) { $record->insert_fields_ordered( MARC::Field->new( '001', $authid ) ); } - #Force UTF-8 in record FIXME CODESPELL (leaded ==> led, lead) + #Force UTF-8 in record $record->encoding('UTF-8'); # warn "REC : ".$record->as_formatted; diff --git a/misc/migration_tools/build_oai_sets.pl b/misc/migration_tools/build_oai_sets.pl index 9a38c4b3e29..70d13b6d8f9 100755 --- a/misc/migration_tools/build_oai_sets.pl +++ b/misc/migration_tools/build_oai_sets.pl @@ -180,7 +180,7 @@ sub print_usage { print "build_oai_sets.pl: Build OAI-PMH sets, according to mappings defined in Koha\n"; print "Usage: build_oai_sets.pl [-h] [-v] [-i] [-l LENGTH [-o OFFSET]]\n\n"; print "\t-h\t\tPrint this help and exit\n"; - print "\t-v\t\the verbose\n"; + print "\t-v\t\t" . " Be verbose\n"; print "\t-i\t\tEmbed items information, mandatory if you defined mappings on item fields\n"; print "\t-l LENGTH\tProcess LENGTH biblios\n"; print "\t-o OFFSET\tIf LENGTH is defined, start processing from OFFSET\n\n"; diff --git a/opac/opac-MARCdetail.pl b/opac/opac-MARCdetail.pl index b2f2fbc913b..e3786764555 100755 --- a/opac/opac-MARCdetail.pl +++ b/opac/opac-MARCdetail.pl @@ -297,7 +297,7 @@ for ( my $tabloop = 0 ; $tabloop <= 9 ; $tabloop++ ) { # now, build item tab ! # the main difference is that datas are in lines and not in columns : thus, we build the first, then the values... # loop through each tag -# warning : we may have FIXME CODESPELL (differents ==> different, difference) number of columns in each row. Thus, we first build a hash, complete it if necessary +# warning : we may have different number of columns in each row. Thus, we first build a hash, complete it if necessary # then construct template. # $record has already had all the item fields filtered above. my @fields = $record->fields(); diff --git a/opac/opac-suggestions.pl b/opac/opac-suggestions.pl index e1101fa667c..4cc90911848 100755 --- a/opac/opac-suggestions.pl +++ b/opac/opac-suggestions.pl @@ -186,7 +186,7 @@ if ( $op eq "cud-add_confirm" ) { push @messages, { type => 'error', code => 'too_many' }; } elsif ( $suggestions->count >= 1 ) { - #some suggestion are answering the request FIXME CODESPELL (Donot ==> Do not, Donut) Add + #some suggestion are answering the request, do not add while ( my $suggestion = $suggestions->next ) { push @messages, { diff --git a/opac/opac-tags.pl b/opac/opac-tags.pl index 165376410bd..dc4b15c7d07 100755 --- a/opac/opac-tags.pl +++ b/opac/opac-tags.pl @@ -342,7 +342,7 @@ if ($add_op) { # Bug 36785: Do not pass biblionumber: get_approval_rows does not 'recognize' biblionumber $results = get_approval_rows($arghash); - stratify_tags( 10, $results ); # work out the FIXME CODESPELL (differents ==> different, difference) sizes for things + stratify_tags( 10, $results ); # work out the different sizes for things my $count = scalar @$results; $template->param( TAGLOOP_COUNT => $count, mine => $mine ); } diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl index 18b7ad64a8e..811c30a9fd0 100755 --- a/suggestion/suggestion.pl +++ b/suggestion/suggestion.pl @@ -257,7 +257,7 @@ if ( $op =~ /cud-save/ ) { my $suggestions = Koha::Suggestions->search_limited($suggestion_only); if ( $suggestions->count ) { - #some suggestion are answering the request FIXME CODESPELL (Donot ==> Do not, Donut) Add + #some suggestion are answering the request, do not add my @messages; while ( my $suggestion = $suggestions->next ) { push @messages, { type => 'error', code => 'already_exists', id => $suggestion->suggestionid }; diff --git a/svc/holds b/svc/holds index 93f0ddd33e3..aa00ab3f803 100755 --- a/svc/holds +++ b/svc/holds @@ -125,7 +125,7 @@ while ( my $h = $holds_rs->next() ) { }; $hold->{transferred} = 0; - $hold->{not_transfered} = 0; + $hold->{not_transferred} = 0; if ($item) { $hold->{itemnumber} = $item->itemnumber(); diff --git a/t/cypress/support/e2e.js b/t/cypress/support/e2e.js index 37a29e26437..cfe78928eee 100644 --- a/t/cypress/support/e2e.js +++ b/t/cypress/support/e2e.js @@ -1298,7 +1298,7 @@ cy.get_title = () => { num_last_vol_online: "num last vol", online_identifier: "online identifier", parent_publication_title_id: "parent id", - preceding_publication_title_id: "FIXME CODESPELL (preceeding ==> preceding, proceeding) id", + preceding_publication_title_id: "preceding id", print_identifier: "print identifier", publication_title: "publication title", publication_type: "journal", diff --git a/t/db_dependent/Acquisition/GetBasketAsCSV.t b/t/db_dependent/Acquisition/GetBasketAsCSV.t index f8d194d4670..773359efe40 100755 --- a/t/db_dependent/Acquisition/GetBasketAsCSV.t +++ b/t/db_dependent/Acquisition/GetBasketAsCSV.t @@ -116,11 +116,11 @@ is( try { my $basket_csv4 = C4::Acquisition::GetBasketAsCSV( $basketno, $query, 'non_existant_profile_id' ); - fail("It is not possible to export basket using non-existant profile"); + fail("It is not possible to export basket using non-existent profile"); } catch { ok( $_->isa("Koha::Exceptions::ObjectNotFound"), - "Using non-existant profile should throw ObjectNotFound exception" + "Using non-existent profile should throw ObjectNotFound exception" ); }; diff --git a/t/db_dependent/Biblio_holdsqueue.t b/t/db_dependent/Biblio_holdsqueue.t index 4170baa8d9d..4ba6de64285 100755 --- a/t/db_dependent/Biblio_holdsqueue.t +++ b/t/db_dependent/Biblio_holdsqueue.t @@ -83,7 +83,7 @@ subtest 'ModBiblio() + holds_queue update tests' => sub { $biblio->frameworkcode, { skip_holds_queue => 0 } ); - # this call FIXME CODESPELL (shoul ==> should, shoal, shawl) not trigger the mocked 'enqueue' + # this call should not trigger the mocked 'enqueue' C4::Biblio::ModBiblio( $biblio->metadata->record, $biblio->id, $biblio->frameworkcode, { skip_holds_queue => 1 } diff --git a/t/db_dependent/Breeding.t b/t/db_dependent/Breeding.t index 237ef8c98c0..8993dab8957 100755 --- a/t/db_dependent/Breeding.t +++ b/t/db_dependent/Breeding.t @@ -132,12 +132,12 @@ sub test_build_translate_query { is( $queries[0] =~ /$str/, 1, 'First Z39.50 query contains ISBN' ); #SRU query should contain translation for ISBN - my $server = { sru_fields => 'isbn=ie-es-bee-en,srchany=overal' }; + my $server = { sru_fields => 'isbn=ie-es-bee-en,srchany=overall' }; my $squery = C4::Breeding::_translate_query( $server, $queries[1] ); is( $squery =~ /ie-es-bee-en/, 1, 'SRU query has translated ISBN index' ); #Another try with fallback to any - $server = { sru_fields => 'srchany=overal' }; + $server = { sru_fields => 'srchany=overall' }; $squery = C4::Breeding::_translate_query( $server, $queries[1] ); is( $squery =~ /overall/, 1, 'SRU query fallback to translated any' ); @@ -170,7 +170,7 @@ sub test_build_translate_query { ); #SRU revisited - $server = { sru_fields => 'isbn=nb,title=dc.title,srchany=overal' }; + $server = { sru_fields => 'isbn=nb,title=dc.title,srchany=overall' }; $squery = C4::Breeding::_translate_query( $server, $queries[1] ); is( $squery =~ /dc.title/ && $squery =~ / and / && $squery =~ /nb=/, 1, 'SRU query with two parameters' ); diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t index 38b8b454e1e..510452c6132 100755 --- a/t/db_dependent/Circulation.t +++ b/t/db_dependent/Circulation.t @@ -2059,7 +2059,7 @@ subtest "Bug 13841 - Do not create new 0 amount fines" => sub { ); my $count = $hr->{count}; - is( $count, 0, "Calling UpdateFine on non-existant fine with an amount of 0 does not result in an empty fine" ); + is( $count, 0, "Calling UpdateFine on non-existent fine with an amount of 0 does not result in an empty fine" ); }; subtest "AllowRenewalIfOtherItemsAvailable tests" => sub { diff --git a/t/db_dependent/Circulation/transferbook.t b/t/db_dependent/Circulation/transferbook.t index 7edfd5b2518..4c51e2104e5 100755 --- a/t/db_dependent/Circulation/transferbook.t +++ b/t/db_dependent/Circulation/transferbook.t @@ -32,12 +32,12 @@ my $schema = Koha::Database->new->schema; $schema->storage->txn_begin; -subtest 'transfer a non-existant item' => sub { +subtest 'transfer a non-existent item' => sub { plan tests => 2; my $library = $builder->build( { source => 'Branch' } ); - #FIXME CODESPELL (Transfert ==> Transfer, Transferred) on unknown barcode + #Transfer on unknown barcode my $item = $builder->build_sample_item(); my $badbc = $item->barcode; $item->delete; diff --git a/t/db_dependent/HoldsQueue.t b/t/db_dependent/HoldsQueue.t index 3234c42d5a7..90b73c1bf2b 100755 --- a/t/db_dependent/HoldsQueue.t +++ b/t/db_dependent/HoldsQueue.t @@ -400,7 +400,7 @@ C4::Calendar->new( branchcode => $branchcodes[0] )->insert_single_holiday( description => "$today", ); -# If the test below is removed, FIXME CODESPELL (aother ==> another, other, mother) tests using the holiday will fail. For some reason if we call is_holiday now +# If the test below is removed, another tests using the holiday will fail. For some reason if we call is_holiday now # the holiday will get set in cache correctly, but not if we let C4::HoldsQueue call is_holiday instead. is( Koha::Calendar->new( branchcode => $branchcodes[0] )->is_holiday($today), 1, diff --git a/t/db_dependent/LDAP/test_ldap_add.pl b/t/db_dependent/LDAP/test_ldap_add.pl index e8768faf2d6..41335fe394b 100755 --- a/t/db_dependent/LDAP/test_ldap_add.pl +++ b/t/db_dependent/LDAP/test_ldap_add.pl @@ -66,7 +66,7 @@ sub ldap_search { $query->code and die sprintf 'error (code:%s) - %s', $query->code, $query->error; my $size = scalar( $query->entries ); my $i = 5; - print "\number of records returned from search: $size.\n"; + print "\n" . "Number of records returned from search: $size." . "\n"; ( $size > $i ) and print "Displaying the last $i records.\n\n"; foreach ( $query->entries ) { ( $size-- > $i ) and next; diff --git a/t/db_dependent/Languages.t b/t/db_dependent/Languages.t index 71a8454c42f..6cbc896963e 100755 --- a/t/db_dependent/Languages.t +++ b/t/db_dependent/Languages.t @@ -27,7 +27,7 @@ my $schema = Koha::Database->new->schema; $schema->storage->txn_begin; my $dbh = C4::Context->dbh; -isnt( C4::Languages::_get_themes(), undef, 'testing _get_themes FIXME CODESPELL (doesnt ==> doesn't, does not) return undef' ); +isnt( C4::Languages::_get_themes(), undef, 'testing _get_themes does not return undef' ); ok( C4::Languages::_get_language_dirs(), 'test getting _get_language_dirs' ); diff --git a/t/db_dependent/Letters.t b/t/db_dependent/Letters.t index 957902cc2e5..4edf7c80f58 100755 --- a/t/db_dependent/Letters.t +++ b/t/db_dependent/Letters.t @@ -224,7 +224,7 @@ isnt( $messages->[0]->{updated_on}, $messages->[0]->{time_queued}, 'Time status changed differs from time queued when status changes' ); -is( dt_from_string( $messages->[0]->{time_queued} ), $yesterday, 'Time queued FIXME CODESPELL (remaines ==> remains, remained) inmutable' ); +is( dt_from_string( $messages->[0]->{time_queued} ), $yesterday, 'Time queued remains inmutable' ); # ResendMessage my $resent = C4::Letters::ResendMessage( $messages->[0]->{message_id} ); diff --git a/t/db_dependent/OAI/Sets.t b/t/db_dependent/OAI/Sets.t index 6cf8de03d40..b1d33acadf5 100755 --- a/t/db_dependent/OAI/Sets.t +++ b/t/db_dependent/OAI/Sets.t @@ -176,7 +176,7 @@ isa_ok( $set, 'HASH', '$set is a hash describing the set whose spec is $oai_sets is( $set->{spec}, 'specSet2', 'spec field is "specSet2"' ); is( $set->{name}, 'nameSet2', 'name field is "nameSet2"' ); -#GetOAISetBySpec does't return the description field. +#GetOAISetBySpec does not return the description field. # ---------- Testing ModOAISet ------------------ ok( !defined(ModOAISet), 'ModOAISet without argument is undef' ); diff --git a/t/db_dependent/Search.t b/t/db_dependent/Search.t index 6c9c7d0bde0..9249bca11dc 100755 --- a/t/db_dependent/Search.t +++ b/t/db_dependent/Search.t @@ -1156,12 +1156,12 @@ sub run_unimarc_search_tests { ['mainentry'], ['and'], [''], ['contains'], ['wil'], 0, 10, '', '', 1 ); - is( $count, 11, 'UNIMARC authorities: hits on mainentry contains "FIXME CODESPELL (wil ==> will, well)"' ); + is( $count, 11, 'UNIMARC authorities: hits on mainentry contains the search term' ); ( $auths, $count ) = SearchAuthorities( ['match'], ['and'], [''], ['contains'], ['wil'], 0, 10, '', '', 1 ); - is( $count, 11, 'UNIMARC authorities: hits on match contains "FIXME CODESPELL (wil ==> will, well)"' ); + is( $count, 11, 'UNIMARC authorities: hits on match contains the search term' ); ( $auths, $count ) = SearchAuthorities( ['mainentry'], ['and'], [''], ['contains'], ['michel'], 0, 20, '', '', 1 diff --git a/t/db_dependent/Serials.t b/t/db_dependent/Serials.t index 3e3e3d18774..1e2e5bbff69 100755 --- a/t/db_dependent/Serials.t +++ b/t/db_dependent/Serials.t @@ -404,7 +404,7 @@ subtest 'GetSubscriptionsFromBiblionumber' => sub { is( C4::Serials::GetSerials(), undef, 'test getting serials when you enter nothing' ); is( C4::Serials::GetSerials2(), undef, 'test getting serials when you enter nothing' ); -is( C4::Serials::GetLatestSerials(), undef, 'test getting FIXME CODESPELL (lastest ==> latest, last) serials' ); +is( C4::Serials::GetLatestSerials(), undef, 'test getting latest serials' ); is( C4::Serials::GetNextSeq(), undef, 'test getting next seq when you enter nothing' ); diff --git a/t/db_dependent/Utils/Datatables_Virtualshelves.t b/t/db_dependent/Utils/Datatables_Virtualshelves.t index 2214f17e45f..aad5127166f 100755 --- a/t/db_dependent/Utils/Datatables_Virtualshelves.t +++ b/t/db_dependent/Utils/Datatables_Virtualshelves.t @@ -188,7 +188,7 @@ t::lib::Mocks::mock_userenv( { patron => $john_doe_patron } ); # Search private lists by title $search_results = C4::Utils::DataTables::VirtualShelves::search( { - shelfname => "FIXME CODESPELL (ist ==> is, it, its, it's, sit, list)", + shelfname => "list", %dt_params, public => 0, } @@ -201,7 +201,7 @@ is( is( $search_results->{recordsFiltered}, 2, - "There should be 2 private shelves with title like '%FIXME CODESPELL (ist ==> is, it, its, it's, sit, list)%" + "There should be 2 private shelves with title like '%list%" ); is( diff --git a/t/db_dependent/api/v1/stockrotationstage.t b/t/db_dependent/api/v1/stockrotationstage.t index e6a45ba94ea..92cc94b2d63 100755 --- a/t/db_dependent/api/v1/stockrotationstage.t +++ b/t/db_dependent/api/v1/stockrotationstage.t @@ -86,11 +86,11 @@ subtest 'move() tests' => sub { $t->put_ok( "//$unauth_userid:$password@/api/v1/rotas/$rota_id/stages/$stage1_id/position" => json => 2 ) ->status_is(403); - # Invalid attempt to move a stage on a non-existant rota + # Invalid attempt to move a stage on a non-existent rota $t->put_ok( "//$auth_userid:$password@/api/v1/rotas/99999999/stages/$stage1_id/position" => json => 2 ) ->status_is(404)->json_is( '/error' => "Rota not found" ); - # Invalid attempt to move an non-existant stage + # Invalid attempt to move an non-existent stage $t->put_ok( "//$auth_userid:$password@/api/v1/rotas/$rota_id/stages/999999999/position" => json => 2 ) ->status_is(404)->json_is( '/error' => "Stage not found" ); -- 2.34.1