From e50a62c97ba8cfb029c3c6cc7d9c5d05d1a86599 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 28 Apr 2025 14:21:59 +0200 Subject: [PATCH] Bug 38010: Improve show/hide password icon Use font-awesome-icon tag and add "hide" Also prevent the scrollbar to jump when the link is clicked (removing href) (cherry picked from commit 78876ee276cf0af6e307cd7a033bbbe2842e1dc1) Signed-off-by: Michaela Sieber Signed-off-by: Jonathan Druart --- .../components/Vendors/VendorInterfaces.vue | 18 +++++++++++++----- .../prog/js/vue/modules/acquisitions.ts | 19 +++++++++++++++---- 2 files changed, 28 insertions(+), 9 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorInterfaces.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorInterfaces.vue index 5ca10306815..5506e83a47c 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorInterfaces.vue +++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorInterfaces.vue @@ -30,18 +30,26 @@
  • + + {{ vi.password }} + - + {{ $__("Show password") }} - - {{ vi.password }} - + + + {{ $__("Hide password") }} +
  • diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/modules/acquisitions.ts b/koha-tmpl/intranet-tmpl/prog/js/vue/modules/acquisitions.ts index 73029da32e0..8772607f04c 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/vue/modules/acquisitions.ts +++ b/koha-tmpl/intranet-tmpl/prog/js/vue/modules/acquisitions.ts @@ -4,17 +4,28 @@ import { createPinia } from "pinia"; import { library } from "@fortawesome/fontawesome-svg-core"; import { - faPlus, + faEye, + faEyeSlash, + faInbox, faMinus, faPencil, - faTrash, + faPlus, faSpinner, - faInbox, + faTrash, } from "@fortawesome/free-solid-svg-icons"; import { FontAwesomeIcon } from "@fortawesome/vue-fontawesome"; import vSelect from "vue-select"; -library.add(faPlus, faMinus, faPencil, faTrash, faSpinner, faInbox); +library.add( + faEye, + faEyeSlash, + faInbox, + faMinus, + faPencil, + faPlus, + faSpinner, + faTrash +); import App from "../components/Vendors/Main.vue"; -- 2.34.1