From 32926a249645c53763d8948e95c8bf1556a0cf7d Mon Sep 17 00:00:00 2001 From: Lucas Gass Date: Mon, 5 May 2025 16:42:31 +0000 Subject: [PATCH] Bug 31698: Fix modals for item level moves --- .../prog/en/modules/reserve/request.tt | 56 +++++++++---------- reserve/request.pl | 2 +- 2 files changed, 29 insertions(+), 29 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt index 6e82b1bfdcd..3d042fe3dfb 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ -1490,39 +1490,36 @@ @@ -1898,6 +1895,7 @@ $(document).ready(function() { $("#itemSearchForm").on("submit", function (event) { event.preventDefault(); + $('#move_hold_item_confirm').prop('disabled' , true ); let externalID = $("#external_id").val(); let apiUrl = `/api/v1/items?external_id=${encodeURIComponent(externalID)}`; @@ -1967,9 +1965,9 @@ $(document).on("change", 'input[name="new_itemnumber"]', function() { $('input[name="new_itemnumber"]').not(this).prop("checked", false); if ( $('input[name="new_itemnumber"]:checked').length ){ - $('#move_hold_item_confirm').show(); + $('#move_hold_item_confirm').prop( 'disabled' , false ); } else { - $('#move_hold_item_confirm').hide(); + $('#move_hold_item_confirm').prop( 'disabled' , true ); } }); @@ -2111,6 +2109,7 @@ $('.move_hold_item').click(function(e) { e.preventDefault(); + $('#move_hold_item_confirm').prop('disabled' , true ); if($('.holds_table .select_hold:checked').length) { $('#itemResultMessage').empty(); $('#move_hold_item_selection table tbody').empty(); @@ -2122,9 +2121,10 @@ let item_level_hold = $(this).data('item_level_hold'); let error_message = $(this).data('item_level_hold') ? "" : _("Cannot move a waiting or record level hold"); let found_status = $(this).data('found'); - $('#move_hold_item_selection table').append(`${reserve_id}Biblionumber: ${reserve_biblionumber} Itemnumber: ${reserve_itemnumber}${error_message}`) if ( item_level_hold ) { - $('#move_hold_item_form').append(``); + $('#move_hold_item_selection table').append(`${reserve_id}Biblionumber: ${reserve_biblionumber} Itemnumber: ${reserve_itemnumber}${error_message}`) + } else { + $('#move_hold_item_selection table').append(`${reserve_id}Biblionumber: ${reserve_biblionumber} Itemnumber: ${reserve_itemnumber}${error_message}`) } }); } diff --git a/reserve/request.pl b/reserve/request.pl index 30142834f39..9440c0add0b 100755 --- a/reserve/request.pl +++ b/reserve/request.pl @@ -112,7 +112,7 @@ if ( $op eq 'cud-move' ) { ); } } elsif ( $op eq 'cud-move_hold_item' or $op eq 'cud-move_hold_biblio' ) { - my @hold_ids = $input->multi_param('hold_id'); + my @hold_ids = $input->multi_param('move_hold_id'); my $original_biblionumber = $input->param('original_biblionumber'); my @moving_holds = Koha::Holds->search( { reserve_id => \@hold_ids }, -- 2.39.5