From f8f91b2eb9e35e09f9d2376b78770661a609020c Mon Sep 17 00:00:00 2001 From: Emmi Takkinen Date: Thu, 8 May 2025 11:27:13 +0300 Subject: [PATCH 1/2] Bug 38356: (follow-up) Fix failing Circulation.t tests After pushing bug 38356 to main, Circulation.t tests started to fail. Fail happened randomly and was related to sub is_serial trying to fetch biblios metadata. This patch changes the way test item is build in "CanBookBeIssued + needsconfirmation message" tests. It seems more reliable to use build_sample_item rather than building item using biblio and biblioitem data. To test prove t/db_dependent/Circulation.t. --- t/db_dependent/Circulation.t | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t index 510452c613..bd49394deb 100755 --- a/t/db_dependent/Circulation.t +++ b/t/db_dependent/Circulation.t @@ -7051,12 +7051,7 @@ subtest "CanBookBeIssued + needsconfirmation message" => sub { my $patron = $builder->build_object( { class => 'Koha::Patrons' } ); my $library = $builder->build_object( { class => 'Koha::Libraries' } ); - my $biblio = $builder->build_object( { class => 'Koha::Biblios' } ); - my $biblioitem = - $builder->build_object( { class => 'Koha::Biblioitems', value => { biblionumber => $biblio->biblionumber } } ); - my $item = $builder->build_object( - { class => 'Koha::Items', value => { itype => $itemtype, biblionumber => $biblio->biblionumber } } ); - + my $item = $builder->build_sample_item; my $hold = $builder->build_object( { class => 'Koha::Holds', -- 2.34.1