From 8344a87d83bcb3dddd489d53046414a203fbdd77 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Wed, 7 May 2025 17:59:25 +0000 Subject: [PATCH] Bug 39857: Fix expanded_avs option for OAI This patch correct the call to filter the record To test: 1 - Enable OAI 2 - Set OAI-PMH:ConfFile to '/var/lib/koha/kohadev/OAI.yaml' 3 - Edit/create the file above to have content: format: marcxml: metadataPrefix: marcxml metadataNamespace: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim schema: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd include_items: 1 expanded_avs: 1 4 - save and restart_all 5 - View some records: http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml 6 - Note the items show coded values 7 - Apply the regressions tests patch 8 - Run: $ ktd --shell k$ prove t/db_dependent/Koha/OAI/Server/Repository.t => FAIL: Tests fail! 9 - Apply this patch 10 - Restart all 11 - Refresh and confirm items now have descriptions 12 - Repeat 8 => SUCCESS: Tests pass! Signed-off-by: Roman Dolny Signed-off-by: Tomas Cohen Arazi Edit (tcohen): Amended the test plan to include the added regression tests run --- Koha/OAI/Server/Repository.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Koha/OAI/Server/Repository.pm b/Koha/OAI/Server/Repository.pm index 0f745e10a6b..071012299bd 100644 --- a/Koha/OAI/Server/Repository.pm +++ b/Koha/OAI/Server/Repository.pm @@ -197,7 +197,7 @@ sub get_biblio_marcxml { $record = $biblio->metadata_record( { embed_items => $with_items, - expand_coded_values => $expanded_avs, + expand_coded_fields => $expanded_avs, interface => 'opac' } ); -- 2.49.0