From 81a37cf9128479c2bf9801321d2d9d8277ca75e6 Mon Sep 17 00:00:00 2001 From: Lucas Gass Date: Mon, 12 May 2025 21:53:45 +0000 Subject: [PATCH] Bug 39883: Do not pass the borrowernumber for NEW_SUGGESTION notices 1. Turn on EmailPurchaseSuggestions and add an email address to EmailAddressForSuggestions. 2. Create a new suggestion and set the " Created by:" field to a patron with an email address 3. Check the message queue ( select * from message_queue where letter_code = "NEW_SUGGESTION" ) 4. There is a NEW_SUGGESTION queued, the to_address should be the email you entered in EmailAddressForSuggestions. 5. The borrowernumber is the borrower who made the suggestion. 6. APPLY PATCH, restart_all 7. Repeat steps 2 - 4. 8. This time a NEW_SUGGESTION should be queued, but the borrowernumber will be undef 9. Check in the patron's notice tab, there should be nothing queued. Signed-off-by: Lin Wei Li --- Koha/Suggestion.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Koha/Suggestion.pm b/Koha/Suggestion.pm index 8a098189b2..47cc5f5566 100644 --- a/Koha/Suggestion.pm +++ b/Koha/Suggestion.pm @@ -110,10 +110,10 @@ sub store { C4::Letters::EnqueueLetter( { - letter => $letter, - borrowernumber => $result->suggestedby, - suggestionid => $result->id, - to_address => $toaddress, + letter => $letter, + borrowernumber => undef, #NEW_SUGGESION notices should not end up in the borrowers notice tab + suggestionid => $result->id, + to_address => $toaddress, message_transport_type => 'email', } ) or warn "can't enqueue letter $letter"; -- 2.43.0