From 7f5f57f1b6ddae5fc6352aabf839f067b30e3bde Mon Sep 17 00:00:00 2001 From: Matt Blenkinsop Date: Thu, 15 May 2025 09:53:47 +0100 Subject: [PATCH] Bug 33430: (follow-up) Handle undefined data in column renders Signed-off-by: Fridolin Somers --- .../prog/en/modules/suggestion/suggestion.tt | 26 ++++++++++++------- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt index 2762234f09..3637c8dee9 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt @@ -1411,10 +1411,13 @@ searchable: true, orderable: true, render: function (data, type, row, meta) { - let node = '%s'.format(row.manager.patron_id, row.manager.surname); - if(row.manager.firstname) node += ', %s'.format(row.manager.firstname); - node += ''; - return node; + if(row?.manager) { + let node = '%s'.format(row.manager?.patron_id, row.manager?.surname); + if(row.manager?.firstname) node += ', %s'.format(row.manager?.firstname); + node += ''; + return node; + } + return '' }, }, { @@ -1430,10 +1433,13 @@ searchable: true, orderable: true, render: function (data, type, row, meta) { - let node = '%s'.format(row.last_modifier.patron_id, row.last_modifier.surname); - if(row.last_modifier.firstname) node += ', %s'.format(row.last_modifier.firstname); - node += ''; - return node; + if(row.last_modifier) { + let node = '%s'.format(row.last_modifier?.patron_id, row.last_modifier?.surname); + if(row.last_modifier?.firstname) node += ', %s'.format(row.last_modifier?.firstname); + node += ''; + return node; + } + return '' }, }, { @@ -1457,7 +1463,7 @@ searchable: false, orderable: true, render: function (data, type, row, meta) { - return escape_str(row.library.name ? row.library.name : ''); + return escape_str(row.library?.name ? row.library.name : ''); }, }, { @@ -1465,7 +1471,7 @@ searchable: false, orderable: true, render: function (data, type, row, meta) { - return escape_str(row.fund ? row.fund.name : ''); + return escape_str(row.fund?.name ? row.fund.name : ''); }, }, { -- 2.43.0