From dcf30f160172d3923ea03a4c91d84fc56de56245 Mon Sep 17 00:00:00 2001 From: Matt Blenkinsop Date: Mon, 19 May 2025 08:39:59 +0000 Subject: [PATCH] Bug 33430: (follow-up) Prevent anonymous suggestions from breaking the table --- .../prog/en/modules/suggestion/suggestion.tt | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt index 3637c8dee96..00e7c6ea0d9 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt @@ -1375,11 +1375,14 @@ orderable: true, render: function (data, type, row, meta) { let suggester = row.suggester; - let node = '%s'.format(suggester.patron_id, suggester.surname); - if(suggester.firstname) node += ', %s'.format(suggester.firstname); - if(suggester.cardnumber) node += ' (%s)'.format(suggester.cardnumber); - node += ''; - return node; + if(suggester) { + let node = '%s'.format(suggester.patron_id, suggester.surname); + if(suggester.firstname) node += ', %s'.format(suggester.firstname); + if(suggester.cardnumber) node += ' (%s)'.format(suggester.cardnumber); + node += ''; + return node; + } + return '' } }, { @@ -1387,7 +1390,7 @@ searchable: false, orderable: true, render: function (data, type, row, meta) { - return escape_str(row.suggester.category.name); + return escape_str(row.suggester ? row.suggester.category.name : ''); }, }, { @@ -1411,7 +1414,7 @@ searchable: true, orderable: true, render: function (data, type, row, meta) { - if(row?.manager) { + if(row.manager) { let node = '%s'.format(row.manager?.patron_id, row.manager?.surname); if(row.manager?.firstname) node += ', %s'.format(row.manager?.firstname); node += ''; -- 2.48.1