From 1c0e2f3959052698e93bcdeaa13f88b2eb0b6ca0 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Wed, 21 May 2025 16:00:10 -0300 Subject: [PATCH] Bug 39960: Improve messages in opac-discharge.tt This patch makes the messages more streamlined. To test: 1. Enable `useDischarge` 2. Have a patron with two checkouts 3. Log into the OPAC and try to request a discharge => FAIL: You get a message that says '2 item(s)' and has redundant words. 4. Check one of the items in 5. Repeat 3 => FAIL: Same, but says '1 item(s)'. 6. Check it in 7. Add a manual fee 8. Repeat 3 => FAIL: Another redundant text about charges. 9. Apply this patch and repeat 2-8 => SUCCESS: Things read better 10. Sign off :-D Signed-off-by: David Nind --- .../opac-tmpl/bootstrap/en/modules/opac-discharge.tt | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discharge.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discharge.tt index 1c1bba80a0..8c27c16d04 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discharge.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discharge.tt @@ -57,17 +57,19 @@ [% ELSE %] [% IF failure %] -

There was an error during the discharge process

+

There was an error during the discharge process

[% END %]
You cannot be discharged because:
    - [% IF discharge_problems.checkouts %] -
  • You have [% discharge_problems.checkouts | html %] item(s) checked out. Please return your checked out items before reapplying.
  • + [% IF discharge_problems.checkouts > 1 %] +
  • You have [% discharge_problems.checkouts | html %] items checked out. Please return them before reapplying.
  • + [% ELSIF discharge_problems.checkouts == 1 %] +
  • You currently have an item checked out. Please return it before reapplying.
  • [% END %] [% IF discharge_problems.debt %] -
  • You have unpaid charges of [% discharge_problems.debt | $Price %]. Please pay your charges before reapplying.
  • +
  • You have unpaid charges of [% discharge_problems.debt | $Price %]. Please pay them before reapplying.
  • [% END %]
-- 2.39.5