From 2582edb3785cafa89296d98149306473b792248c Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Tue, 21 May 2013 12:18:59 -0400 Subject: [PATCH] Bug 10300 - Revert Bug 8781 - Access to Transfer page while "independent branches" is on This bug needs reverted, this explanation was given to me by a librarian: For our group it is useful in order to allow the library to "fix" items that they receive from other libraries for holds requests that have either not been transferred properly by the lending library, so the item was never processed through check in to be placed "in transit," -- there are frequent enough occasions when a library is filling hold requests from their queue and the transfer is not completely placed into effect -- the status will be changed to "in transit" but the "Current Location" is not updated to the borrowing library. In these instances, the item arrives at the borrowing location, they scan it at check in and get the message "Item must be checked in at home library." In both of these cases, without the "Transfer" ability, I have to make the transfer for them. This is not a workable situation. It is far too manual a system if I have to personally transfer items to libraries myself to correct both of these situations. Test Plan: 1) As a non-superlibrarian, navigate to circulation-home.pl 2) Note the transfer option is non-existant 3) Apply this patch 4) Refresh circulation-home.pl 5) Note the transfer option is displayed This reverts commit c101f779e587217ae5ac46ee18aa0292c30aa808. --- circ/circulation-home.pl | 5 +---- .../prog/en/modules/circ/circulation-home.tt | 2 -- 2 files changed, 1 insertions(+), 6 deletions(-) diff --git a/circ/circulation-home.pl b/circ/circulation-home.pl index 5eee81b..842f8d9 100755 --- a/circ/circulation-home.pl +++ b/circ/circulation-home.pl @@ -25,7 +25,7 @@ use C4::Context; use C4::Koha; my $query = new CGI; -my ($template, $loggedinuser, $cookie, $flags) +my ($template, $loggedinuser, $cookie) = get_template_and_user({template_name => "circ/circulation-home.tmpl", query => $query, type => "intranet", @@ -37,8 +37,5 @@ my ($template, $loggedinuser, $cookie, $flags) my $fa = getframeworkinfo('FA'); $template->param( fast_cataloging => 1 ) if (defined $fa); -# Checking if the transfer page needs to be displayed -$template->param( display_transfer => 1 ) if ( ($flags->{'superlibrarian'} == 1) || (C4::Context->preference("IndependantBranches") == 0) ); - output_html_with_http_headers $query, $cookie, $template->output; diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt index f5e82b4..50995ce 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt @@ -19,9 +19,7 @@