Bugzilla – Attachment 18304 Details for
Bug 7718
Remove itemnumber column from serials table
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7718 - Remove itemnumber column from serials table
Bug-7718---Remove-itemnumber-column-from-serials-t.patch (text/plain), 1.95 KB, created by
Jonathan Druart
on 2013-05-22 10:41:25 UTC
(
hide
)
Description:
Bug 7718 - Remove itemnumber column from serials table
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2013-05-22 10:41:25 UTC
Size:
1.95 KB
patch
obsolete
>From 9b592b352f893221b9ad77ab2372ecf3678bc921 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 4 Feb 2013 08:16:58 -0500 >Subject: [PATCH] Bug 7718 - Remove itemnumber column from serials table > >Remove the column 'itemnumber' from the table 'serial'. This is >a 1 to many relationship, and this reference does not make sense. >The 'serialitems' table handles the relationship between the 'items' >table and the 'serial' table. > >Test Plan: >1) Apply patch >2) Run updatedatabase.pl >3) Verify serial.itemnumber has been removed from the database > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> > >Column removed. No errors. > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >--- > installer/data/mysql/kohastructure.sql | 1 - > installer/data/mysql/updatedatabase.pl | 7 +++++++ > 2 files changed, 7 insertions(+), 1 deletion(-) > >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index 7cea46e..ca2f2b2 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -1900,7 +1900,6 @@ CREATE TABLE `serial` ( > `planneddate` date default NULL, > `notes` text, > `publisheddate` date default NULL, >- `itemnumber` text default NULL, > `claimdate` date default NULL, > `routingnotes` text, > PRIMARY KEY (`serialid`) >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index 61c0de0..a29ffdc 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -6935,6 +6935,13 @@ INSERT INTO permissions (module_bit, code, description) VALUES > SetVersion($DBversion); > } > >+$DBversion ="3.13.00.XXX"; >+if ( CheckVersion($DBversion) ) { >+ $dbh->do("ALTER TABLE serial DROP itemnumber"); >+ print "Upgrade to $DBversion done (Bug 7718 - Remove itemnumber column from serials table)\n"; >+ SetVersion($DBversion); >+} >+ > =head1 FUNCTIONS > > =head2 TableExists($table) >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7718
:
9118
|
15031
|
15071
|
15073
| 18304