From f51f684ec31ef39070dd3fa0576fe7eeac716c23 Mon Sep 17 00:00:00 2001 From: Laura_Escamilla Date: Tue, 24 Jun 2025 16:29:54 +0000 Subject: [PATCH] =?UTF-8?q?Bug=2039371:=20Limit=20"Holds=20to=20place"=20i?= =?UTF-8?q?nput=20based=20on=20holds=5Fper=5Frecord=20rule=20and=20prompt?= =?UTF-8?q?=20for=20multiple=20holds=20To=20test:=201.=20Go=20to=20place?= =?UTF-8?q?=20a=20hold=20for=20a=20patron.=20Under=20"Hold=20next=20availa?= =?UTF-8?q?ble=20item,"=20the=20"Holds=20to=20place=20(count)"=20field=20s?= =?UTF-8?q?hould=20default=20to=201.=E2=80=A8Before=20applying=20the=20pat?= =?UTF-8?q?ch,=20this=20input:=20=20=20=20=20*=20Has=20no=20maximum=20limi?= =?UTF-8?q?t=20=20=20=20=20*=20Allows=20entry=20of=20any=20number,=20even?= =?UTF-8?q?=20extremely=20high=20values=20=20=20=20=20*=20Does=20not=20sho?= =?UTF-8?q?w=20a=20confirmation=20prompt=202.=20Apply=20the=20patch.=203.?= =?UTF-8?q?=20Repeat=20step=201.=20Now:=20=20=20=20=20*=20The=20maximum=20?= =?UTF-8?q?number=20of=20holds=20allowed=20is=20based=20on=20the=20holds?= =?UTF-8?q?=5Fper=5Frecord=20circulation=20rule=20=20=20=20=20=20=20=20=20?= =?UTF-8?q?*=20If=20holds=5Fper=5Frecord=20is=20set=20(e.g.,=202),=20you?= =?UTF-8?q?=20cannot=20enter=20more=20than=20that=20=20=20=20=20=20=20=20?= =?UTF-8?q?=20*=20If=20it's=20blank=20(meaning=20unlimited),=20no=20max=20?= =?UTF-8?q?is=20set=20=20=20=20=20*=20A=20note=20appears=20under=20the=20i?= =?UTF-8?q?nput:=20=20=20=20=20=20=20=20=20*=20=E2=80=9CThe=20maximum=20nu?= =?UTF-8?q?mber=20of=20holds=20to=20place=20is=202.=E2=80=9D=20(or=20whate?= =?UTF-8?q?ver=20the=20rule=20is)=20=20=20=20=20=20=20=20=20*=20Or:=20?= =?UTF-8?q?=E2=80=9CThere=20is=20no=20set=20maximum=20for=20holds.?= =?UTF-8?q?=E2=80=9D=20if=20blank=20=20=20=20=20*=20If=20you=20enter=20mor?= =?UTF-8?q?e=20than=201,=20you=20will=20see=20a=20confirmation=20prompt:?= =?UTF-8?q?=20=20=20=20=20=20=20=20=20*=20=E2=80=9CAre=20you=20sure=20you?= =?UTF-8?q?=20want=20to=20place=203=20hold(s)=3F=E2=80=9D=20=20=20=20=20*?= =?UTF-8?q?=20If=20you=20enter=201=20hold,=20it=20proceeds=20without=20pro?= =?UTF-8?q?mpting=204.=20Try=20entering=200=20or=20leaving=20the=20field?= =?UTF-8?q?=20blank:=20=20=20=20=20*=20The=20minimum=20is=20enforced=20as?= =?UTF-8?q?=201=20=20=20=20=20*=20The=20system=20defaults=20back=20to=20pl?= =?UTF-8?q?acing=201=20hold=205.=20Confirm=20that=20the=20input=20box:=20?= =?UTF-8?q?=20=20=20=20*=20Allows=20up/down=20arrows=20if=20a=20numeric=20?= =?UTF-8?q?max=20is=20set=20=20=20=20=20*=20Behaves=20correctly=20with=20k?= =?UTF-8?q?eyboard=20input=20=20=20=20=20*=20Respects=20the=20configured?= =?UTF-8?q?=20circulation=20rule=206.=20Sign=20off=20and=20have=20an=20ama?= =?UTF-8?q?zing=20day!=20=F0=9F=8E=89?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../prog/en/modules/reserve/request.tt | 902 +++++++++--------- 1 file changed, 463 insertions(+), 439 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt index 1a949d3c4b..c38ef6f2f0 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ -661,7 +661,21 @@ [% UNLESS remaining_holds_for_record == 1 %]
  • - + + [% IF max_holds_for_record %] +

    The maximum number of holds to place is [% max_holds_for_record %].

    + [% ELSE %] +

    There is no set maximum for holds.

    + [% END %]
  • [% ELSE %] @@ -1432,507 +1446,517 @@ [% END %]